Spec URL: https://fedorapeople.org/~qwan/freshmaker/freshmaker.spec SRPM URL: https://fedorapeople.org/~qwan/freshmaker/freshmaker-0.0.4-1.src.rpm Description: Hi! I have packaged up freshmaker and would appreciate a review so we can get it into Fedora. Freshmaker is a service scheduling rebuilds of artifacts as new content becomes available. For example, when modulemd yaml of a module changed in dist-git and freshmaker received the message from fedmsg, an event will be generated and triggers a rebuild of that module by sending a module build request to Module Build System. More detail info can refer to: https://pagure.io/freshmaker Fedora Account System Username: qwan
Quick note from the beginning, a lot of python- prefixed packages. Those must be python2- (if python2 version is needed) and like it is only if python2- prefixed packages don't exist. Also, if you use koji as a python library you must requires python2-koji instead of koji.
Hi Igor, Thanks for your comments, the remaining python-* packages are all available in python-* prefix only which I checked in fedora koji build system. python2-koji is available from koji-1.13 on fedora >= 25, so I have change the spec to have: %if 0%{?fedora} && 0%{?fedora} >= 25 BuildRequires: python2-koji %else BuildRequires: koji %endif %if 0%{?fedora} && 0%{?fedora} >= 25 Requires: python2-koji %else Requires: koji %endif
(In reply to Qixiang Wan from comment #2) > Hi Igor, > > Thanks for your comments, the remaining python-* packages are all available > in python-* prefix only which I checked in fedora koji build system. pyOpenSSL -> python2-pyOpenSSL python-six -> python2-six python-sqlalchemy -> python2-sqlalchemy ... > > python2-koji is available from koji-1.13 on fedora >= 25, so I have change > the spec to have: > > %if 0%{?fedora} && 0%{?fedora} >= 25 > BuildRequires: python2-koji > %else > BuildRequires: koji > %endif > > %if 0%{?fedora} && 0%{?fedora} >= 25 > Requires: python2-koji > %else > Requires: koji > %endif This is wrong, python2-koji is available everywhere.
(In reply to Igor Gnatenko from comment #3) > (In reply to Qixiang Wan from comment #2) > > Hi Igor, > > > > Thanks for your comments, the remaining python-* packages are all available > > in python-* prefix only which I checked in fedora koji build system. > pyOpenSSL -> python2-pyOpenSSL > python-six -> python2-six > python-sqlalchemy -> python2-sqlalchemy > ... I see, I only checked the package name, but they are available as sub-packages. I will check all these python-* packages. Thanks for pointing this out. > > > > python2-koji is available from koji-1.13 on fedora >= 25, so I have change > > the spec to have: > > > > %if 0%{?fedora} && 0%{?fedora} >= 25 > > BuildRequires: python2-koji > > %else > > BuildRequires: koji > > %endif > > > > %if 0%{?fedora} && 0%{?fedora} >= 25 > > Requires: python2-koji > > %else > > Requires: koji > > %endif > This is wrong, python2-koji is available everywhere. I checked this with koji build system: this is a koji-1.12 build, and it doesn't have python2-koji sub-package: https://koji.fedoraproject.org/koji/buildinfo?buildID=900888 and this is a koji-1.13 build, which includes python2-koji: https://koji.fedoraproject.org/koji/buildinfo?buildID=900888 If I understand it correctly, koji doesn't support python3 prior to 1.13, so there is no python2-koji for old versions, and I didn't see 1.13 builds for fedora <=24 in: https://koji.fedoraproject.org/koji/packageinfo?packageID=1181, so I think we need to check fedora dist for koji.
(In reply to Qixiang Wan from comment #4) > (In reply to Igor Gnatenko from comment #3) > > (In reply to Qixiang Wan from comment #2) > > > Hi Igor, > > > > > > Thanks for your comments, the remaining python-* packages are all available > > > in python-* prefix only which I checked in fedora koji build system. > > pyOpenSSL -> python2-pyOpenSSL > > python-six -> python2-six > > python-sqlalchemy -> python2-sqlalchemy > > ... > > I see, I only checked the package name, but they are available as > sub-packages. I will check all these python-* packages. Thanks for pointing > this out. > Had another check against these python-* packages: python-enum34: Latest build doesn't has python2-enum34, only old versions has python2-enum, so doesn't need to change this. python-fedora: Latest build has python2-fedora on fedora >= 24, but not actually available even in fedora 25 updates, so I'd like to keep python-fedora. pyOpenSSL: Latest build has python2-pyOpenSSL on fedora >= 26, but since fedora 26 is not GA yet, I'd like to keep pyOpenSSL and update it after 26 GA if necessary. python-six, python-sqlalchemy: similar to pyOpenSSL, there are only python2- versions for them from fedora 26. python-flask-script, python-httplib2, python-munch: All available with python-* packages only. Based on that, I think it's unnecessary to change the existing remaining python-* packages at this moment.
Beside of that, I found python2-koji is not available for Fedora 25 from updates repo yet, so it can cause problem to have python2-koji before it's available in updates. python2-koji can not be found in: https://download-ib01.fedoraproject.org/pub/fedora/linux/updates/25/x86_64/p/
Updated some of the python- prefix packages per comments from Igor. Spec URL: https://fedorapeople.org/~qwan/freshmaker/freshmaker.spec SRPM URL: https://fedorapeople.org/~qwan/freshmaker/freshmaker-0.0.4-1.fc26.src.rpm
Latest version: Spec URL: https://fedorapeople.org/~qwan/freshmaker/freshmaker.spec SRPM URL: https://fedorapeople.org/~qwan/freshmaker/freshmaker-0.0.4-1.src.rpm
apart from broken SourceURL and useless systemd requires/buildrequires, I can't complain about anything ;)
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/freshmaker
freshmaker-0.0.4-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-3b2316552a
freshmaker-0.0.4-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-3b2316552a
freshmaker-0.0.6-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-5980624af0
freshmaker-0.0.6-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-5980624af0
freshmaker-0.0.6-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.