Red Hat Bugzilla – Bug 1469179
invoke checkpatch.pl with strict
Last modified: 2017-09-05 13:36:59 EDT
Description of problem:
We seem to follow most of the coding guidelines which are checked in strict mode in checkpatch.pl. It would save a lot of time for new contributors and maintainers if these warnings are shown *before* sending the patch.
REVIEW: https://review.gluster.org/17737 (rfc.sh: make alignment check compulsory) posted (#1) for review on master by Raghavendra Talur (firstname.lastname@example.org)
COMMIT: https://review.gluster.org/17737 committed in master by Niels de Vos (email@example.com)
Author: Raghavendra Talur <firstname.lastname@example.org>
Date: Mon Jul 10 20:43:39 2017 +0530
rfc.sh: make alignment check compulsory
Earlier, it was not reported if a function call had arguments on next
line and the args were not aligned to opening bracket. With this change,
it is a check that is displayed in output.
I have not analyzed what all --strict brings in. If it is found to be
more restrictive than required, we may choose to promote this *one* CHK
to WARN and stop using --strict.
CHECK: Alignment should match open parenthesis
+ ret = gf_asprintf (&footer,
+ " [%s]", strerror(errnum));
total: 0 warnings, 1 checks, 8 lines checked
Signed-off-by: Raghavendra Talur <email@example.com>
CentOS-regression: Gluster Build System <firstname.lastname@example.org>
Smoke: Gluster Build System <email@example.com>
Reviewed-by: Prashanth Pai <firstname.lastname@example.org>
Reviewed-by: Jeff Darcy <email@example.com>
Reviewed-by: Sonal Arora <firstname.lastname@example.org>
Reviewed-by: Niels de Vos <email@example.com>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.
glusterfs-3.12.0 has been announced on the Gluster mailinglists , packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist  and the update infrastructure for your distribution.