Description of problem: We seem to follow most of the coding guidelines which are checked in strict mode in checkpatch.pl. It would save a lot of time for new contributors and maintainers if these warnings are shown *before* sending the patch.
REVIEW: https://review.gluster.org/17737 (rfc.sh: make alignment check compulsory) posted (#1) for review on master by Raghavendra Talur (rtalur)
COMMIT: https://review.gluster.org/17737 committed in master by Niels de Vos (ndevos) ------ commit 43d55c5afb1a9f731d806f7893923ac999b9ef6c Author: Raghavendra Talur <rtalur> Date: Mon Jul 10 20:43:39 2017 +0530 rfc.sh: make alignment check compulsory Earlier, it was not reported if a function call had arguments on next line and the args were not aligned to opening bracket. With this change, it is a check that is displayed in output. I have not analyzed what all --strict brings in. If it is found to be more restrictive than required, we may choose to promote this *one* CHK to WARN and stop using --strict. Sample: CHECK: Alignment should match open parenthesis + ret = gf_asprintf (&footer, + " [%s]", strerror(errnum)); total: 0 warnings, 1 checks, 8 lines checked Change-Id: I48834087efcae872b69746ba962b0bb1c130b5cd BUG: 1469179 Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: https://review.gluster.org/17737 CentOS-regression: Gluster Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Prashanth Pai <ppai> Reviewed-by: ankitraj Reviewed-by: Jeff Darcy <jeff.us> Reviewed-by: Sonal Arora <sarora> Reviewed-by: Niels de Vos <ndevos>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report. glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html [2] https://www.gluster.org/pipermail/gluster-users/