Bug 1469487 - sys_xxx() functions should guard against bad return values from fs
Summary: sys_xxx() functions should guard against bad return values from fs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-11 11:30 UTC by Pranith Kumar K
Modified: 2018-03-15 11:17 UTC (History)
2 users (show)

Fixed In Version: glusterfs-4.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-15 11:17:12 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Pranith Kumar K 2017-07-11 11:30:52 UTC
Description of problem:
    Problem:
    FS sometimes doesn't give the expected return values. We need our common
    functions to guard against this.
    Example BUG: https://bugzilla.redhat.com/show_bug.cgi?id=864401
    
    Fix:
    When the return value is not as per specification, change the return value
    to -1 and errno to EIO


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-07-11 11:32:04 UTC
REVIEW: https://review.gluster.org/17746 (libglusterfs: Handle FS errors gracefully) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 2 Worker Ant 2017-07-11 13:41:47 UTC
REVIEW: https://review.gluster.org/17746 (libglusterfs: Handle FS errors gracefully) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 3 Worker Ant 2017-07-11 14:12:47 UTC
REVIEW: https://review.gluster.org/17746 (libglusterfs: Handle FS errors gracefully) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 4 Worker Ant 2017-07-14 04:47:25 UTC
REVIEW: https://review.gluster.org/17746 (libglusterfs: Handle FS errors gracefully) posted (#4) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 5 Worker Ant 2017-07-14 17:40:50 UTC
REVIEW: https://review.gluster.org/17746 (libglusterfs: Handle FS errors gracefully) posted (#5) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 6 Worker Ant 2017-07-15 00:59:50 UTC
REVIEW: https://review.gluster.org/17746 (libglusterfs: Handle FS errors gracefully) posted (#6) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 7 Worker Ant 2017-07-15 01:48:22 UTC
REVIEW: https://review.gluster.org/17746 (libglusterfs: Handle FS errors gracefully) posted (#7) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 8 Worker Ant 2017-07-15 10:11:10 UTC
REVIEW: https://review.gluster.org/17746 (libglusterfs: Handle FS errors gracefully) posted (#8) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 9 Worker Ant 2017-07-15 14:43:40 UTC
REVIEW: https://review.gluster.org/17746 (libglusterfs: Handle FS errors gracefully) posted (#9) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 10 Worker Ant 2017-07-15 15:58:48 UTC
REVIEW: https://review.gluster.org/17746 (libglusterfs: Handle FS errors gracefully) posted (#10) for review on master by Xavier Hernandez (xhernandez)

Comment 11 Worker Ant 2017-07-18 07:00:15 UTC
REVIEW: https://review.gluster.org/17746 (libglusterfs: Handle FS errors gracefully) posted (#11) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 12 Worker Ant 2017-08-22 08:29:47 UTC
REVIEW: https://review.gluster.org/18083 (libglusterfs: Handle FS errors gracefully) posted (#1) for review on experimental by Amar Tumballi (amarts)

Comment 13 Worker Ant 2017-08-22 09:32:29 UTC
REVIEW: https://review.gluster.org/18083 (libglusterfs: Handle FS errors gracefully) posted (#2) for review on experimental by Amar Tumballi (amarts)

Comment 14 Worker Ant 2017-08-22 12:26:06 UTC
REVIEW: https://review.gluster.org/18083 (libglusterfs: Handle FS errors gracefully) posted (#3) for review on experimental by Amar Tumballi (amarts)

Comment 15 Worker Ant 2017-08-23 01:22:29 UTC
COMMIT: https://review.gluster.org/18083 committed in experimental by Amar Tumballi (amarts) 
------
commit dbd0d50eed0d89d7a42292f96cf5ae192e107a07
Author: Amar Tumballi <amarts>
Date:   Fri Aug 18 16:05:32 2017 +0530

    libglusterfs: Handle FS errors gracefully
    
    Problem:
    FS sometimes doesn't give the expected return values. We need our common
    functions to guard against this.
    Example BUG: https://bugzilla.redhat.com/show_bug.cgi?id=864401
    
    Fix:
    When the return value is not as per specification, change the return value
    to -1 and errno to EIO
    
    BUG: 1469487
    Change-Id: I14739ab2e5ae225b1a91438b87f8928af56f2934
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: https://review.gluster.org/18083
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    Tested-by: Amar Tumballi <amarts>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 16 Worker Ant 2017-10-30 08:20:54 UTC
REVIEW: https://review.gluster.org/17746 (libglusterfs: Handle FS errors gracefully) posted (#12) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 17 Worker Ant 2017-11-22 10:08:11 UTC
COMMIT: https://review.gluster.org/17746 committed in master by \"Pranith Kumar Karampuri\" <pkarampu> with a commit message- libglusterfs: Handle FS errors gracefully

Problem:
FS sometimes doesn't give the expected return values. We need our common
functions to guard against this.
Example BUG: https://bugzilla.redhat.com/show_bug.cgi?id=864401

Fix:
When the return value is not as per specification, change the return value
to -1 and errno to EIO

BUG: 1469487
Change-Id: I14739ab2e5ae225b1a91438b87f8928af56f2934
Signed-off-by: Pranith Kumar K <pkarampu>

Comment 18 Worker Ant 2017-12-06 12:33:57 UTC
REVIEW: https://review.gluster.org/18951 (libglusterfs: Handle FS errors gracefully) posted (#1) for review on experimental by Kotresh HR

Comment 19 Worker Ant 2017-12-06 15:10:14 UTC
COMMIT: https://review.gluster.org/18951 committed in experimental by \"Kotresh HR\" <khiremat> with a commit message- libglusterfs: Handle FS errors gracefully

Problem:
FS sometimes doesn't give the expected return values. We need our common
functions to guard against this.
Example BUG: https://bugzilla.redhat.com/show_bug.cgi?id=864401

Fix:
When the return value is not as per specification, change the return value
to -1 and errno to EIO

BUG: 1469487
Change-Id: Id23fdbcf7aefc4f779e76db824cb4c74d580de1f
Signed-off-by: Pranith Kumar K <pkarampu>

Comment 20 Shyamsundar 2018-03-15 11:17:12 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.0.0, please open a new bug report.

glusterfs-4.0.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-March/000092.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.