Does your .spec build and pass tests? 2.4 broke things...

My spec is building fine with rpmbuild -bb, but not in mock, because of:
help2man: can't get `--help' info from /builddir/build/BUILDROOT/rubygem-jekyll-3.5.0-1.fc26.x86_64/usr/bin/jekyll
help2man: can't get `--help' info from /builddir/build/BUILDROOT/rubygem-jekyll-3.5.0-1.fc26.x86_64/usr/bin/jekyll

You can see full build log here: https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-26-x86_64/00578916-rubygem-jekyll/build.log.gz

Sorry, I've posted previous comment to the wrong bug. Building is working fine for latest rubygem-addressable, see https://copr.fedorainfracloud.org/coprs/frantisekz/fedora-developer-portal/build/578917/

In that case, let's get this rolled into Fedora w/o copr, you want to co-maintain with me?

(In reply to Shawn Starr from comment #4)
> In that case, let's get this rolled into Fedora w/o copr, you want to
> co-maintain with me?

Sure, but keep in mind that I am not very experienced packager (my first Review Request is still pending :) ).

So, it looks like I'll have to wait till my Review Request is finished before becoming a co-maintainer.

Anyway, I think you can move forward and update rubygem-addressable in Rawhide so dependency tree up to my Review Request can be satisfied.

I'll take a look at this this week and get this into rawhide

If this passes scratch build in koji I'll just release your spec (modified) to rawhide for 27.

Are we not doing any %check tests anymore? This fails otherwise w/o the require BuildDependencies

What is our policy on not performing tests?

It builds fine w/o tests but, if our policy requires them, we need further work on the .spec

"If there is test suite available for the package (even separately, for example not included in the gem but available in the upstream repository), it should be run in %check. The test suite is the only automated tool which can assure basic functionality of the package. Running it is especially helpful when mass rebuilds are required. You may skip test suite execution when not all build dependencies are met but this must be documented in the specfile. The missing build dependencies to enable the test suite should be packaged for Fedora as soon as possible and the test suite re-enabled."

We definitely should be doing tests. My SPEC file was created with gem2rpm without any modifications. 

Regarding failing tests, it looks like the issue origins from this:
https://github.com/sporkmonger/addressable/commit/f1d5855162c48d06eb1907871909d5859b9a7d3c

which adds Dependency on git gem (which is not available in Fedora). I think disabling the test which was introduced in this commit would be easiest path forward.

Patching shouldn't be too difficult, I can take a look at it tomorrow.

So, I've made patch(check SRPM if you wanna look at it) to be able to run the test suite during rpm build without too much burden. Some of the tests are unfortunately failing (I've added "|| :" to continue building anyway), 1357 examples, 6 failures, 5 pending

SPEC: https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-rawhide-x86_64/00585054-rubygem-addressable/rubygem-addressable.spec

SRPM: https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-rawhide-x86_64/00585054-rubygem-addressable/rubygem-addressable-2.5.1-2.fc27.src.rpm

I don't think I'll be able to do anything with test fails though. Is this acceptable? Should I try to contact upstream about this?


Failed examples:

rspec ./spec/addressable/uri_spec.rb:404 # Addressable::URI when initialized from individual components returns 'com' for #tld
rspec ./spec/addressable/uri_spec.rb:2392 # Addressable::URI when parsed from 'HTTP://EXAMPLE.COM/' should have a tld of 'com'
rspec ./spec/addressable/uri_spec.rb:2407 # Addressable::URI when parsed from 'http://www.example.co.uk/' should have a tld of 'co.uk'
rspec ./spec/addressable/uri_spec.rb:2411 # Addressable::URI when parsed from 'http://www.example.co.uk/' should have a domain of 'example.co.uk'
rspec ./spec/addressable/uri_spec.rb:2426 # Addressable::URI when parsed from 'http://sub_domain.blogspot.com/' should have a tld of 'com'
rspec ./spec/addressable/uri_spec.rb:2430 # Addressable::URI when parsed from 'http://sub_domain.blogspot.com/' should have a domain of 'blogspot.com'

Hey Shawn,
is my solution good enough for now or do we need to have all tests passing? If it's OK, can we move forward and update rawhide at least?

Hi František, if those tests are not critical, It would be sad if we release a package that users are developing with that breaks because they are using those functionalities.

This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle.
Changing version to '27'.

Shawn, I can't parse your last comment. Are you saying that the package should be updated or not?

I'm saying you're sure those failures don't break the actual use of the package then let's comment out those checks.

Have you tried to use this code as it is now? Does it work for your dependency?

If we push this package and we get regressions in other packages using rubygem-addressable then we have to fix the code.

SPEC: https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-rawhide-x86_64/00591675-rubygem-addressable/rubygem-addressable.spec
SRPM: https://github.com/frantisekz/content/releases/download/temp/rubygem-addressable-2.5.1-3.fc26.src.rpm

Build with tests is failing in mock (it is ok with rpmbuild), see log[0]. It's weird because:
> dnf provides "/usr/share/gems/gems/rspec-core-3.6.0/lib/rspec/core/formatters/progress_formatter.rb"

but:
/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:133:in `require': cannot load such file -- rspec/core/formatters/progress_formatter (LoadError)

rubygem-rspec-core-3.6.0-1.fc26.1.noarch : Rspec-2 runner and formatter

Should I report bug against rubygem-rspec-core ?

[0] https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-rawhide-x86_64/00591675-rubygem-addressable/build.log.gz

Sorry, I made typo in last comment, correct part:

> dnf provides "/usr/share/gems/gems/rspec-core-3.6.0/lib/rspec/core/formatters/progress_formatter.rb"

rubygem-rspec-core-3.6.0-1.fc26.1.noarch : Rspec-2 runner and formatter

With great help of Vít Ondruch, here is the version with tests running correctly even in mock.

SPEC: https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-rawhide-x86_64/00592650-rubygem-addressable/rubygem-addressable.spec
SRPM: https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-rawhide-x86_64/00592650-rubygem-addressable/rubygem-addressable-2.5.1-4.fc28.src.rpm

Shawn, I think you can go forward and update this in Rawhide. It's so soon after branching, we'll have plenty of time to find out potential issues in F28.

PS, I've forgot to fill comments for patches in .spec:

> # Revert f1d5855162c48d06eb1907871909d5859b9a7d3c (rack-mount)
> %patch0
> # Backport commit to fix more tests
> %patch1
> # Comment out failing tests
> %patch2

Ok, I'll roll this into rawhide today

Today that is :)

Testing this against 2.5.2 which just came out...

You might want to drop this patch for 2.5.2: 

Patch1: 0002-Request-URI-methods-handle-URI-with-uppercase-letter.patch

Shawn, I've updated SPEC/SRPM for 2.5.2, removed Patch1: 0002-Request-URI-methods-handle-URI-with-uppercase-letter.patch and fixed warning: Could not load native IDN implementation.

SPEC: https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-rawhide-x86_64/00594726-rubygem-addressable/rubygem-addressable.spec

SRPM: https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-rawhide-x86_64/00594726-rubygem-addressable/rubygem-addressable-2.5.2-1.fc28.src.rpm

Builds fine in mock (without internet access as it is in Koji). I think we're good to go here for F28.

This is now pushed to rawhide, thanks!

Well not yet... it build scratch but gives me 404 error in koji...looking at why during dependency download...

Something wrong:

https://kojipkgs.fedoraproject.org//work/tasks/257/21530257/root.log

I don't know what it's referring to for 404 in terms of what it's trying to download for dependencies. It didn't download ruby though...

Its a repo issue, closing, i'll keep trying to build until the issue is resolved but the packaging is good to go.

Not a repo issue, for some reason my build didn't push the .gem into the sources repo. Now the build is completed.