Bug 1471137 - mem-pool: mem_pool_fini() doesn't release entire memory allocated
Summary: mem-pool: mem_pool_fini() doesn't release entire memory allocated
Keywords:
Status: CLOSED EOL
Alias: None
Product: GlusterFS
Classification: Community
Component: libgfapi
Version: 3.11
Hardware: All
OS: All
unspecified
high
Target Milestone: ---
Assignee: Niels de Vos
QA Contact: bugs@gluster.org
URL:
Whiteboard:
Depends On: 1470170
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-14 13:41 UTC by Niels de Vos
Modified: 2018-06-20 18:29 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-20 18:29:59 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2017-07-14 13:41:20 UTC
+++ This bug was initially created as a clone of Bug #1470170 +++

Description of problem:

At the moment, all the work which mem_pool_fini() does is to exit and cleanup the sweeper thread. That doesn't ensure that all the memory allocated is cleaned up as some of those allocations may still be in hot list or if in cold list, sweeper thread may not have got chance to run through them.
hence we need to iterate though all those per-thread mem-pools and clean them up as part of fini()

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Niels de Vos on 2017-07-12 20:02:48 CEST ---

I'm looking into this with help from https://github.com/gluster/gluster-debug-tools/tree/master/gfapi-load-volfile

--- Additional comment from Worker Ant on 2017-07-13 13:58:57 CEST ---

REVIEW: https://review.gluster.org/17768 (mem-pool: free objects from pools on mem_pools_fini()) posted (#1) for review on master by Niels de Vos (ndevos)

--- Additional comment from Worker Ant on 2017-07-14 11:31:22 CEST ---

REVIEW: https://review.gluster.org/17768 (mem-pool: free objects from pools on mem_pools_fini()) posted (#2) for review on master by Niels de Vos (ndevos)

--- Additional comment from Worker Ant on 2017-07-14 15:37:50 CEST ---

REVIEW: https://review.gluster.org/17768 (mem-pool: free objects from pools on mem_pools_fini()) posted (#3) for review on master by Niels de Vos (ndevos)

--- Additional comment from Worker Ant on 2017-07-14 15:37:54 CEST ---

REVIEW: https://review.gluster.org/17778 (mem-pool: remove references to unused ctx->mempool_list) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 1 Shyamsundar 2018-06-20 18:29:59 UTC
This bug reported is against a version of Gluster that is no longer maintained
(or has been EOL'd). See https://www.gluster.org/release-schedule/ for the
versions currently maintained.

As a result this bug is being closed.

If the bug persists on a maintained version of gluster or against the mainline
gluster repository, request that it be reopened and the Version field be marked
appropriately.


Note You need to log in before you can comment on or make changes to this bug.