Bug 1471366 - Posix xlator needs to reserve disk space to prevent the brick from getting full.
Summary: Posix xlator needs to reserve disk space to prevent the brick from getting full.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: posix
Version: mainline
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: Mohit Agrawal
QA Contact:
URL:
Whiteboard:
Depends On: 1464350
Blocks: 1173519 1286092 1398595
TreeView+ depends on / blocked
 
Reported: 2017-07-15 11:34 UTC by Mohit Agrawal
Modified: 2017-12-08 17:34 UTC (History)
5 users (show)

Fixed In Version: glusterfs-3.13.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1464350
Environment:
Last Closed: 2017-12-08 17:34:10 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Mohit Agrawal 2017-07-15 11:34:32 UTC
+++ This bug was initially created as a clone of Bug #1464350 +++

Description of problem:

Once a brick becomes completely (100%) full, the gluster filesystem becomes inconsistent as xattr operations fail and recovery is very difficult.

A rebalance cannot be used to migrate data off the full brick as xattr operations will fail.

DHT uses a min-free-disk option to try to keep some reserve space on all bricks. However, this approach is not fool proof and should ideally be handled by the posix xlator. 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Red Hat Bugzilla Rules Engine on 2017-06-23 03:48:47 EDT ---

This bug is automatically being proposed for the current release of Red Hat Gluster Storage 3 under active development, by setting the release flag 'rhgs‑3.3.0' to '?'. 

If this bug should be proposed for a different release, please manually change the proposed release flag.

--- Additional comment from Red Hat Bugzilla Rules Engine on 2017-06-28 05:09:20 EDT ---

This BZ having been considered, and subsequently not approved to be fixed at the RHGS 3.3.0 release, is being proposed for the next minor release of RHGS

Comment 1 Worker Ant 2017-07-15 12:35:16 UTC
REVIEW: https://review.gluster.org/17780 (posix: Needs to reserve disk space to prevent the brick from getting full) posted (#1) for review on master by MOHIT AGRAWAL (moagrawa)

Comment 2 Worker Ant 2017-07-16 02:50:02 UTC
REVIEW: https://review.gluster.org/17780 (posix: Needs to reserve disk space to prevent the brick from getting full) posted (#2) for review on master by MOHIT AGRAWAL (moagrawa)

Comment 3 Worker Ant 2017-07-16 08:01:42 UTC
REVIEW: https://review.gluster.org/17780 (posix: Needs to reserve disk space to prevent the brick from getting full) posted (#3) for review on master by MOHIT AGRAWAL (moagrawa)

Comment 4 Worker Ant 2017-07-22 12:52:50 UTC
REVIEW: https://review.gluster.org/17780 (posix: Needs to reserve disk space to prevent the brick from getting full) posted (#4) for review on master by MOHIT AGRAWAL (moagrawa)

Comment 5 Worker Ant 2017-07-22 12:56:27 UTC
REVIEW: https://review.gluster.org/17780 (posix: Needs to reserve disk space to prevent the brick from getting full) posted (#5) for review on master by MOHIT AGRAWAL (moagrawa)

Comment 6 Worker Ant 2017-07-22 13:54:47 UTC
REVIEW: https://review.gluster.org/17780 (posix: Needs to reserve disk space to prevent the brick from getting full) posted (#6) for review on master by MOHIT AGRAWAL (moagrawa)

Comment 7 Worker Ant 2017-07-24 04:59:55 UTC
REVIEW: https://review.gluster.org/17780 (posix: Needs to reserve disk space to prevent the brick from getting full) posted (#7) for review on master by MOHIT AGRAWAL (moagrawa)

Comment 8 Worker Ant 2017-07-25 04:15:13 UTC
REVIEW: https://review.gluster.org/17780 (posix: Needs to reserve disk space to prevent the brick from getting full) posted (#8) for review on master by MOHIT AGRAWAL (moagrawa)

Comment 9 Worker Ant 2017-07-25 05:32:49 UTC
REVIEW: https://review.gluster.org/17780 (posix: Needs to reserve disk space to prevent the brick from getting full) posted (#9) for review on master by MOHIT AGRAWAL (moagrawa)

Comment 10 Worker Ant 2017-07-25 15:36:59 UTC
COMMIT: https://review.gluster.org/17780 committed in master by Jeff Darcy (jeff.us) 
------
commit eb266ade1e2da5739ed66495755ec2784a5bf74b
Author: Mohit Agrawal <moagrawa>
Date:   Sat Jul 15 17:55:14 2017 +0530

    posix: Needs to reserve disk space to prevent the brick from getting full
    
    Problem: Currently there is no option available at posix xlator to save the
             disk from getting full
    
    Solution: Introduce a new option storage.reserve at posix xlator to
              configure disk threshold.posix xlator spawn a thread to update the
              disk space status in posix private structure and same flag is checked
              by every posix fop before start operation.If flag value is 1 then
              it sets op_errno to ENOSPC and goto out from the fop.
    
    BUG: 1471366
    Change-Id: I98287cd409860f4c754fc69a332e0521bfb1b67e
    Signed-off-by: Mohit Agrawal <moagrawa>
    Reviewed-on: https://review.gluster.org/17780
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    Reviewed-by: Jeff Darcy <jeff.us>

Comment 11 Shyamsundar 2017-12-08 17:34:10 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.