Bug 1471833 - [RFE] Allow passing extra ansible opts to oVirt Metrics shell script
Summary: [RFE] Allow passing extra ansible opts to oVirt Metrics shell script
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-metrics
Classification: oVirt
Component: RFEs
Version: 1.0.5
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ovirt-4.2.0
: ---
Assignee: Shirly Radco
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks: oVirt-Metrics-and-Logs 1475135 1502931 1513015
TreeView+ depends on / blocked
 
Reported: 2017-07-17 14:11 UTC by Shirly Radco
Modified: 2019-04-28 14:11 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
: 1502931 (view as bug list)
Environment:
Last Closed: 2017-12-20 10:55:46 UTC
oVirt Team: Metrics
Embargoed:
rule-engine: ovirt-4.2+
gklein: testing_plan_complete+
ylavi: planning_ack+
sradco: devel_ack+
lsvaty: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 80565 0 master MERGED Allow passing extra opts to ansible 2017-08-13 12:10:58 UTC
oVirt gerrit 82133 0 master ABANDONED Allow passing extra opts to configure_ovirt_hosts_for_metrics.sh 2017-09-25 09:22:56 UTC
oVirt gerrit 82155 0 master MERGED remove configure_ovirt_hosts_for_metrics.sh 2017-09-26 05:40:26 UTC

Description Shirly Radco 2017-07-17 14:11:18 UTC
Description of problem:
Today we run the configure_ovirt_machines_for_metrics.sh script that does a few tasks and then runs the ansible playbook with defined parameters.

We would like to embed the shell tasks in the ansible playbook and run the playbook directly.

Comment 1 Shirly Radco 2017-08-13 12:09:13 UTC
We added an option to pass native ansible parameters.
This will allow more flexibility when running the script.

Test should verify that extra ansible parameters, like -v, are passed as expected.

Comment 2 Lukas Svaty 2017-09-21 15:59:16 UTC
not working for playbook for hosts:

/usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_hosts_for_metrics.sh -vvv

=> no verbose output

tested in ovirt-engine-metrics-1.1.1-0.0.master.20170919065728.el7.centos.noarch

Comment 3 Shirly Radco 2017-09-24 12:42:46 UTC
This should work for Please run:
/usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_machine_for_metrics.sh -vvv

Comment 4 Lukas Svaty 2017-09-25 08:19:48 UTC
(In reply to Shirly Radco from comment #3)
> This should work for Please run:
> /usr/share/ovirt-engine-metrics/setup/ansible/
> configure_ovirt_machine_for_metrics.sh -vvv

The patch is still on POST. Please note comment#2 where it was verified for configure_ovirt_machine_for_metrics.sh however failing for configure_ovirt_hosts_for_metrics.sh that is fixed in Didis patch. 

Please do not move bugs to ON_QA before patches are merged or QA has proper builds.

Comment 5 Shirly Radco 2017-09-25 09:19:53 UTC
Since /usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_hosts_for_metrics.sh only add --scope=hosts, I'll remove this script so we will only have one ansible script to configure oVirt metrics.

Comment 6 Lukas Svaty 2017-10-04 15:23:53 UTC
verified in ovirt-engine-metrics-1.1.1-0.0.master.20171001113530.el7.centos.noarch

Comment 7 Sandro Bonazzola 2017-12-20 10:55:46 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.