Bug 1472679 - Review Request: perl-MooX-Locale-TextDomain-OO - Provide API used in translator modules without translating
Review Request: perl-MooX-Locale-TextDomain-OO - Provide API used in translat...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Pisar
Fedora Extras Quality Assurance
:
Depends On: 1472377
Blocks: 1465429
  Show dependency treegraph
 
Reported: 2017-07-19 04:24 EDT by Jitka Plesnikova
Modified: 2017-07-20 06:27 EDT (History)
2 users (show)

See Also:
Fixed In Version: perl-MooX-Locale-TextDomain-OO-0.001-1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-07-20 06:27:11 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ppisar: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Jitka Plesnikova 2017-07-19 04:24:53 EDT
Spec URL: https://jplesnik.fedorapeople.org/perl-MooX-Locale-TextDomain-OO/perl-MooX-Locale-TextDomain-OO.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-MooX-Locale-TextDomain-OO/perl-MooX-Locale-TextDomain-OO-0.001-1.fc27.src.rpm

Description:
This module provides API used in translator modules without translating.

Fedora Account System Username: jplesnik@redhat.com
Comment 1 Petr Pisar 2017-07-19 07:58:12 EDT
URL and Source0 addresses are Ok.
Source0 archive (SHA-256: 5b8e52cffdd84a95d368ca10b943541b996a93e0d06396f4fe19335688e4173d) is Ok.
Summary verified in lib/MooX/Locale/TextDomain/OO.pm. Ok.
Description verified in lib/MooX/Locale/TextDomain/OO.pm. Ok.
License verified in README.md and lib/MooX/Locale/TextDomain/OO.pm. Ok.
No XS code, noarch BuildArch is Ok.
BuildRequires are Ok.
All tests pass. Ok.

$ rpmlint perl-MooX-Locale-TextDomain-OO.spec ../SRPMS/perl-MooX-Locale-TextDomain-OO-0.001-1.fc27.src.rpm ../RPMS/noarch/perl-MooX-Locale-TextDomain-OO-0.001-1.fc27.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-MooX-Locale-TextDomain-OO-0.001-1.fc27.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jul 19 13:50 /usr/share/doc/perl-MooX-Locale-TextDomain-OO
-rw-r--r--    1 root    root                      125 Jun  1 10:52 /usr/share/doc/perl-MooX-Locale-TextDomain-OO/Changes
-rw-r--r--    1 root    root                     2128 May 31 20:24 /usr/share/doc/perl-MooX-Locale-TextDomain-OO/README.md
-rw-r--r--    1 root    root                     1996 Jul 19 13:50 /usr/share/man/man3/MooX::Locale::TextDomain::OO.3pm.gz
drwxr-xr-x    2 root    root                        0 Jul 19 13:50 /usr/share/perl5/vendor_perl/MooX
drwxr-xr-x    2 root    root                        0 Jul 19 13:50 /usr/share/perl5/vendor_perl/MooX/Locale
drwxr-xr-x    2 root    root                        0 Jul 19 13:50 /usr/share/perl5/vendor_perl/MooX/Locale/TextDomain
-rw-r--r--    1 root    root                     2843 May 31 20:24 /usr/share/perl5/vendor_perl/MooX/Locale/TextDomain/OO.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-MooX-Locale-TextDomain-OO-0.001-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(Carp)
      1 perl(Locale::TextDomain::OO)
      1 perl(Moo) >= 1.003
      1 perl(Moo::Role)
      1 perl(MooX::Locale::Passthrough)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Do not run-require `perl(Moo)', move the version constrain to `perl(Moo::Role)'.

$ rpm -q --provides -p ../RPMS/noarch/perl-MooX-Locale-TextDomain-OO-0.001-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(MooX::Locale::TextDomain::OO) = 0.001
      1 perl-MooX-Locale-TextDomain-OO = 0.001-1.fc27
Binary provides are Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct the `FIX' item before building this package.
Resolution: Package APPROVED.
Comment 2 Gwyn Ciesla 2017-07-19 18:54:53 EDT
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-MooX-Locale-TextDomain-OO
Comment 3 Jitka Plesnikova 2017-07-20 06:27:11 EDT
Thank you for the review and the repository.

Note You need to log in before you can comment on or make changes to this bug.