Bug 1472812 - Running engine-host-update.py does not work with RHVH / RHEVH hosts
Running engine-host-update.py does not work with RHVH / RHEVH hosts
Status: POST
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine (Show other bugs)
3.6.10
All All
medium Severity medium
: ovirt-3.6.z-async
: ---
Assigned To: Lev Veyde
Jiri Belka
: ZStream
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-19 08:44 EDT by Lukas Svaty
Modified: 2017-09-15 02:57 EDT (History)
12 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: Integration
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
oVirt gerrit 81687 master POST packaging: Update engine-host-update for RHEVH 2017-09-13 05:03 EDT

  None (edit)
Description Lukas Svaty 2017-07-19 08:44:00 EDT
Description of problem:
Running engine-host-update.py for RHVH hosts

Version-Release number of selected component (if applicable):
ovirt-engine-4.1.4.2-0.1.el7.noarch

How reproducible:
100%

Steps to Reproduce:
1. run `./engine-host-update.py --insecure --engine=localhost --username=admin@internal --password=mypass` --host=rhevh

Actual results:
RHVH host is reinstalled. Updates still available.

Expected results:
When host is upgraded properly.
Comment 1 Yaniv Lavi (Dary) 2017-07-31 05:11:17 EDT
Which version is the RHVH host are you trying to update?
Comment 2 Lukas Svaty 2017-07-31 05:47:11 EDT
It was upgrade 4.1.3 -> 4.1.4 candidate.
However problem is not in host, rather in the utility, current flow:

1. Deactivate host
2. Reinstall host
3. Activate host

Reinstall host uses this code:

host.install(
            ovirtsdk.xml.params.Action(
                ssh=ovirtsdk.xml.params.SSH(
                    authentication_method='publickey'
                ),
                host=ovirtsdk.xml.params.Host(override_iptables=True),
            )
        )

My wild guess:
This method reinstalls the current image
a) for rhel hosts installs the packages and redeploy vdsm/libvirt..., which is correct
b)for rhevh it I believe it just reinstalls the current image, even that new image is available. For new image to be installed, upgrade should be used, not install/reinstall.
Comment 3 Yaniv Lavi (Dary) 2017-08-07 05:06:07 EDT
Do we want to fix this?
When is the Ansible to do this planned to be released?
Comment 4 Dan Kenigsberg 2017-08-21 08:32:58 EDT
(In reply to Yaniv Lavi (Dary) from comment #3)
> Do we want to fix this?

I do. Most of our install base is using RHVH.

> When is the Ansible to do this planned to be released?

4.1.6, according to Bug 1473535
Comment 5 Yaniv Lavi (Dary) 2017-08-30 05:11:08 EDT
Making this work with the vintage node is more critical, than RHVH.
Comment 6 Jiri Belka 2017-08-31 05:39:42 EDT
(In reply to Yaniv Lavi (Dary) from comment #5)
> Making this work with the vintage node is more critical, than RHVH.

I talked to mperina@ and he clarified how 'install' works.

1. first 'host.install' action does check what is host type:
   - if EL host, it _only_ installs packages which should are defined in
     host-deploy code
   - if node (and legacy?) it supposes it has all packages available

2. even "installing" packages on EL host does _NOT_ update all packages. These
   are defined in the DB (PackageNamesForCheckUpdate), thus simple 'host.install'
   won't update all packages in (PackageNamesForCheckUpdate).

3. for node/ngn I suppose 'host.install' does not touch any packaging and
   upgrade-manager updates 'ovirt-node-ng-image-update'
   ('OvirtNodePackageNamesForCheckUpdate' in DB) to update node/ngn.

Thus to update node/ngn (and to correct vds_type if it has been wrong) it would need to to reinstall ('host.install') and tell upgrade-manager to upgrade it as well.

Note You need to log in before you can comment on or make changes to this bug.