Bug 1473018 - Conflicts with python2-bcrypt
Summary: Conflicts with python2-bcrypt
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: py-bcrypt
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-19 20:52 UTC by fednuc
Modified: 2018-05-29 11:52 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-05-29 11:52:27 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description fednuc 2017-07-19 20:52:21 UTC
Because py-bcrypt conflicts with python2-bcrypt, it's not possible to simultaneously install packages dependent on the former (for example matrix-synapse) and packages dependent on the latter (e.g. bzr, deja-dup).

Matrix is one of the most promising federated instant messaging protocols under development (potentially IRC without the XEP mess, or Signal without being forced to use a single company's servers), and having its reference server (matrix-synapse) in Fedora is great for ease of adoption.

Having to remove default-installed backup software to install a Matrix server works against this unfortunately, so would be great if there's a way of fixing this.

Comment 1 fednuc 2017-07-19 20:54:03 UTC
Identical Arch bug: https://bugs.archlinux.org/task/54475

Comment 2 Gwyn Ciesla 2017-07-20 13:59:15 UTC
So far as I can tell python-bcrypt is only used by python-paramiko, whereas py-bcrypt is used by matrix-synapse, pagure, python-totpcgi, and commissaire-client.

python-bcrypt is the more actively maintained, so in a perfect world I'd like to see everything move to python-bcrypt, but I don't know how feasible that is.  If that's possible, that should happen and py-bcrypt should be retired.  Do you know anything about how compatible the modules are?

Comment 3 fednuc 2017-07-20 15:53:14 UTC
Yes but a bunch of stuff requires python-paramiko (unfortunately the --tree option of 'dnf repoquery' doesn't work properly to list them).

According to the readme of the bcrypt module (aka python-bcrypt) https://github.com/pyca/bcrypt/blob/master/README.rst:

"This library should be compatible with py-bcrypt and it will run on Python 2.6+, 3.3+, and PyPy 2.6+."

I had a quick chat with a dev on #matrix-dev on Freenode and informally they think it should be compatible too.

Comment 4 Gwyn Ciesla 2017-08-08 16:43:42 UTC
So if I change the Requires on matrix-synapse, pagure, python-totpcgi and commissaire-client to python-bcrypt, set the proper obsoletes/provides on python-bcrypt, and retire py-bcrypt, we should be good?

Comment 5 fednuc 2017-08-08 20:12:10 UTC
Yes in theory sounds about right, but I haven't tested it ;)

Comment 6 Gwyn Ciesla 2017-08-09 15:45:45 UTC
Ok, I've got the changes ready and will push and build.  I've CCd the relevant maintainers.  In a few days I'll push this to f26.

Comment 7 Gwyn Ciesla 2017-08-09 15:48:33 UTC
I'm not retiring py-pcrypt until both this is confirmed, and retire works following the pagure.io move.

Comment 8 Pierre-YvesChibon 2017-08-10 08:13:37 UTC
python-bcrypt is not a drop-in replacement for py-bcrypt, try running pagure's unit-tests with it and you will see.

So sorry but I'm un-doing your commit on the pagure package until pagure is ready to cope with this change.

Comment 9 fednuc 2017-08-10 09:16:07 UTC
(In reply to Pierre-YvesChibon from comment #8)
> python-bcrypt is not a drop-in replacement for py-bcrypt, try running
> pagure's unit-tests with it and you will see.

Useful to know. Do you know what the incompatibilities are? Has there been discussion with upstream python-bcrypt about remedying them, since their README says it "should be compatible"? Or has addressing them been WONTFIXed by them?

Comment 10 Pierre-YvesChibon 2017-08-10 10:08:14 UTC
IIRC the difference has to do with bytes vs unicode, I don't remember more details from the top of my head though.

Comment 11 fednuc 2017-08-10 12:46:04 UTC
Has it been discussed with upstream python-bcrypt?

Comment 12 Gwyn Ciesla 2017-08-10 13:15:09 UTC
(In reply to Pierre-YvesChibon from comment #8)
> python-bcrypt is not a drop-in replacement for py-bcrypt, try running
> pagure's unit-tests with it and you will see.
> 
> So sorry but I'm un-doing your commit on the pagure package until pagure is
> ready to cope with this change.

Did you undo any other commits?  The commits to python-bcrypt will need to be reverted.

Comment 13 Pierre-YvesChibon 2017-08-10 13:27:59 UTC
> Has it been discussed with upstream python-bcrypt?

I didn't, don't know if someone else did.

> Did you undo any other commits?

I just reverted the BuildRequires/Requires changes on pagure.spec, nothing else.

Comment 14 Fedora End Of Life 2018-05-03 08:09:25 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 15 Edgar Hoch 2018-05-15 01:32:09 UTC
It seams, that the same (or similar?) error still exists in Fedora 28.


# LANG=C dnf install python2-py-bcrypt python2-bcrypt
...
Error: Transaction check error:
  file /usr/lib64/python2.7/site-packages/bcrypt/__init__.py from install of python2-py-bcrypt-0.4-15.fc28.x86_64 conflicts with file from package python2-bcrypt-3.1.4-3.fc28.x86_64
  file /usr/lib64/python2.7/site-packages/bcrypt/__init__.pyc from install of python2-py-bcrypt-0.4-15.fc28.x86_64 conflicts with file from package python2-bcrypt-3.1.4-3.fc28.x86_64
  file /usr/lib64/python2.7/site-packages/bcrypt/__init__.pyo from install of python2-py-bcrypt-0.4-15.fc28.x86_64 conflicts with file from package python2-bcrypt-3.1.4-3.fc28.x86_64
  file /usr/lib64/python2.7/site-packages/bcrypt/_bcrypt.so from install of python2-py-bcrypt-0.4-15.fc28.x86_64 conflicts with file from package python2-bcrypt-3.1.4-3.fc28.x86_64

Comment 16 Fedora End Of Life 2018-05-29 11:52:27 UTC
Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26
is no longer maintained, which means that it will not receive any
further security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.