Bug 1473389 - Review Request: gnome-shell-extension-pixel-saver - A GNOME Shell extension designed to save pixels by fusing activity and title bar
Summary: Review Request: gnome-shell-extension-pixel-saver - A GNOME Shell extension d...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2017-07-20 16:44 UTC by Oles Pidgornyy
Modified: 2020-07-11 00:47 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-11 00:47:31 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Oles Pidgornyy 2017-07-20 16:44:30 UTC
Spec URL: https://pidgornyy.fedorapeople.org/review/gnome-shell-extension-pixel-saver.spec
SRPM URL: https://pidgornyy.fedorapeople.org/review/gnome-shell-extension-pixel-saver-1.10-1.fc26.src.rpm
Description: Pixel Saver is an extension for GNOME Shell that merges the activity bar and title bar of maximized windo
ws. It is especially interesting for small screens.
Fedora Account System Username: pidgornyy

The spec is based on existing gnome-shell-extensions like https://src.fedoraproject.org/cgit/rpms/gnome-shell-extension-no-topleft-hot-corner.git

It requires no compilation.

Successful build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20630584

Comment 1 c72578 2017-07-25 12:14:59 UTC
Please have a look at the following error and warning reported by rpmlint:

E: description-line-too-long C Pixel Saver is an extension for GNOME Shell that merges the activity bar and title bar of maximized windows. It is especially interesting for small screens.

https://fedoraproject.org/wiki/Common_Rpmlint_issues#description-line-too-long
- Split your description across multiple lines, ensuring that each line does not exceed 79 characters.

W: incoherent-version-in-changelog 0.8.0 ['1.10-1.fc26', '1.10-1']


Concerning the SPEC file:

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).

Comment 2 c72578 2017-07-25 12:20:31 UTC
The LICENSE file says:
The MIT License

Copyright (C) 2013 Amaury Séchet

Please correct in the SPEC file:
GPLv3 -> MIT

Comment 3 Package Review 2020-07-10 00:56:01 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 4 Package Review 2020-07-11 00:47:31 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.