Bug 1473678 - Review Request: perl-Shell-Config-Generate - Portably generate configuration for any shell
Summary: Review Request: perl-Shell-Config-Generate - Portably generate configuration ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1473663
Blocks: 1473705
TreeView+ depends on / blocked
 
Reported: 2017-07-21 12:19 UTC by Petr Pisar
Modified: 2017-08-03 14:19 UTC (History)
2 users (show)

Fixed In Version: perl-Shell-Config-Generate-0.26-1.fc27
Clone Of:
Environment:
Last Closed: 2017-08-03 14:19:43 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-07-21 12:19:58 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Shell-Config-Generate/perl-Shell-Config-Generate.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Shell-Config-Generate/perl-Shell-Config-Generate-0.26-1.fc27.src.rpm
Description:
This Perl module provides an interface for specifying shell configurations for
different shell environments without having to worry about the arcane
differences between shells such as csh, sh, cmd.exe and command.com.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-08-03 12:27:36 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Shell-Config-Generate-0.26-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(Shell::Guess) >= 0.02
      1 perl(strict)
      1 perl(:VERSION) >= 5.8.1
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Shell-Config-Generate-0.26-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Shell::Config::Generate) = 0.26
      1 perl-Shell-Config-Generate = 0.26-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Shell-Config-Generate*
perl-Shell-Config-Generate.noarch: W: spelling-error Summary(en_US) Portably -> Port ably, Port-ably, Portable
perl-Shell-Config-Generate.noarch: W: spelling-error %description -l en_US csh -> sch, cs, ch
perl-Shell-Config-Generate.noarch: W: spelling-error %description -l en_US cmd -> cm, cad, cod
perl-Shell-Config-Generate.noarch: W: spelling-error %description -l en_US exe -> ex, exes, exec
perl-Shell-Config-Generate.src: W: spelling-error Summary(en_US) Portably -> Port ably, Port-ably, Portable
perl-Shell-Config-Generate.src: W: spelling-error %description -l en_US csh -> sch, cs, ch
perl-Shell-Config-Generate.src: W: spelling-error %description -l en_US cmd -> cm, cad, cod
perl-Shell-Config-Generate.src: W: spelling-error %description -l en_US exe -> ex, exes, exec
2 packages and 1 specfiles checked; 0 errors, 8 warnings.
Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-08-03 13:00:39 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Shell-Config-Generate

Comment 3 Petr Pisar 2017-08-03 14:19:43 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.