Bug 1474069 - [Packaging] Please don't ship source file packages
[Packaging] Please don't ship source file packages
Status: NEW
Product: Fedora
Classification: Fedora
Component: eclipse-pydev (Show other bugs)
26
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Mat Booth
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-23 10:47 EDT by Christian Stadelmann
Modified: 2017-07-24 14:15 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Christian Stadelmann 2017-07-23 10:47:56 EDT
Version-Release number of selected component (if applicable):
eclipse-pydev-5.8.0-1.fc26.x86_64

How reproducible:
always (caused by packaging)

Steps to Reproduce:
1. download or install eclipse-pydev
2. have a look at the internal file structure

Actual results:
for every folder in /usr/lib/eclipse/plugins, eclipse-pydev contains a source .jar file

Expected results:
Do not contain a source .jar file. Most of the code is written in python, so source code is not required. Source code belongs into a SRPM file.

Additional info:
See https://fedoraproject.org/wiki/Packaging:Guidelines#Source_RPM_Buildtime_Macros for details.
Comment 1 Mat Booth 2017-07-24 05:20:44 EDT
I'm not sure this is true. Can you give an example?

The first few I looked at, e.g.:

..../com.python.pydev_5.8.0.v20170616-0956/pydev.jar
..../com.python.pydev.analysis_5.8.0.v20170616-0956/analysis.jar
..../com.python.pydev.debug_5.8.0.v20170616-0956/debug.jar

These contain only bytecode (i.e. *.class files) and no source at all.

Upstream Pydev makes the choice to install dir-shaped bundles, with the Java bytecode contained in embedded jars that are referenced from the bundle manifest with the "Bundle-ClassPath" directive.

This is admittedly a non-standard way to ship a plug-in, but it is valid nonetheless.
Comment 2 Christian Stadelmann 2017-07-24 14:15:42 EDT
The folder where the source files are installed: /usr/lib/eclipse/droplets/pydev-core/eclipse/plugins

An example: com.python.pydev.debug.source_5.8.0.v20170616-0956.jar in that folder.

PS: sorry, I put the wrong path in comment #0.

Note You need to log in before you can comment on or make changes to this bug.