Bug 1474309 - Disperse: Coverity issue
Summary: Disperse: Coverity issue
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: disperse
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sunny Kumar
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-24 11:56 UTC by Sunny Kumar
Modified: 2017-12-08 17:35 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.13.0
Clone Of:
Environment:
Last Closed: 2017-12-08 17:35:17 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Sunny Kumar 2017-07-24 11:56:48 UTC
Description of problem:
Coverity scan result:
https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-07-21-88af8d7a/html/

EC Issue:
https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-07-21-88af8d7a/html/1/7ec-common.c.html#error:12


Version-Release number of selected component (if applicable):
master

How reproducible:


Steps to Reproduce:
Coverity

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-07-24 12:06:56 UTC
REVIEW: https://review.gluster.org/17860 (cluster/ec: Fix coverity issue) posted (#1) for review on master by Anonymous Coward

Comment 2 Worker Ant 2017-07-25 09:10:35 UTC
REVIEW: https://review.gluster.org/17860 (cluster/ec: Fix coverity issue) posted (#2) for review on master by Sunny Kumar

Comment 3 Worker Ant 2017-07-31 06:57:28 UTC
REVIEW: https://review.gluster.org/17860 (cluster/ec: Fix coverity issue) posted (#3) for review on master by Sunny Kumar

Comment 4 Worker Ant 2017-09-02 14:03:15 UTC
REVIEW: https://review.gluster.org/18186 (cluster/ec: fix for BAD_SHIFT, follow-up patch) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 5 Worker Ant 2017-09-15 13:33:07 UTC
REVIEW: https://review.gluster.org/18186 (cluster/ec: fix for BAD_SHIFT, follow-up patch) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 6 Worker Ant 2017-09-15 13:52:39 UTC
REVIEW: https://review.gluster.org/18186 (cluster/ec: fix for BAD_SHIFT, follow-up patch) posted (#3) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 7 Worker Ant 2017-09-20 09:40:33 UTC
COMMIT: https://review.gluster.org/18186 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 6b30347f65c9590fa1b636e4aed0471dc8eeff07
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Sat Sep 2 09:49:06 2017 -0400

    cluster/ec: fix for BAD_SHIFT, follow-up patch
    
    Address comments to https://review.gluster.org/18067, (Change-Id
    I86e15d12939c610c99f5f96c551bb870df20f4b4)
    
    Which was posted as an RFC as an example of a possible alternative
    fix to https://review.gluster.org/17860 (Change-Id
    I28a3bdd4a357526dba0cf84c262919c05cfa173e)
    
    An alternative fix that preserved the unsignedness of the indexes
    throughout, obviating the need to check its value before using it to
    shift. (shift by negative number is undefined, as is shift by more
    bits than in the type.)
    
    BUG: 1474309
    Change-Id: I46fe9cec140d3397463780748f6876251acb06dd
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>

Comment 8 Shyamsundar 2017-12-08 17:35:17 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.