Spec URL: https://www.scrye.com/~kevin/fedora/review/python-pytest-fixture-config/python-pytest-fixture-config.spec SRPM URL: https://www.scrye.com/~kevin/fedora/review/python-pytest-fixture-config/python-pytest-fixture-config-1.2.11-1.fc27.src.rpm Description: Simple configuration objects for Py.test fixtures Fedora Account System Username: kevin rpmlint says: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. koji scratch build: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. This package is needed for python-setuptools tests.
Created attachment 1305478 [details] review.txt
There is only one thing that must be fixed for approval: the package does need py.test so it should Require it. Other than that, I had a few optional suggestions: * If you use github for Source0, you can include the LICENSE file. It introduces some other questions though, since the git repo contains other packages too. See the attached review.txt for details. * I recommend filing a bug against python3 to get it to own the __pycache__ folder. Anyways, I'm prepared to approve if you add the requirements on py.test.
ok, -2 at the same place with the requires added: Spec URL: https://www.scrye.com/~kevin/fedora/review/python-pytest-fixture-config/python-pytest-fixture-config.spec SRPM URL: https://www.scrye.com/~kevin/fedora/review/python-pytest-fixture-config/python-pytest-fixture-config-1.2.11-2.fc27.src.rpm I thought about using the github project, but I think that would just complicate things more since all those other things are there in the same repo.
Created attachment 1305655 [details] review-2.txt
Looks good!
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-fixture-config