Spec URL: https://github.com/eclipseo/packaging/blob/ec6f7c0/golang-github-billziss-gh-cgofuse.spec SRPM: https://kojipkgs.fedoraproject.org//work/tasks/5254/20795254/golang-github-billziss-gh-cgofuse-0-0.1.git35bcf03.fc27.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20795251 Fedora Account System Username: eclipseo This is one of the many build dependencies for rclone, bug #1473314, handling FUSE in Go. I am still looking for a sponsorship, please consider me. Thank you.
Fixed ExclusiveArch issue Spec URL: https://github.com/eclipseo/packaging/blob/27b7add/golang-github-billziss-gh-cgofuse.spec SRPM: https://kojipkgs.fedoraproject.org//work/tasks/1674/20801674/golang-github-billziss-gh-cgofuse-0-0.1.git35bcf03.fc27.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20801674
SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584400-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584400-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse-0-0.1.git35bcf03.fc27.src.rpm FAS username: eclipseo
Added commitdate SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591302-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591302-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse-0-0.1.20170616.git35bcf03.fc27.src.rpm FAS username: eclipseo
Hi Robert, I am taking this one. - If they are to be packaged, the files under examples directory should be under %doc - Upstream does provide versions, have you considered using them? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-billziss-gh-cgofuse-devel-0-0.1.20170616.git35bcf03.fc27.noarch.rpm golang-github-billziss-gh-cgofuse-unit-test-devel-0-0.1.20170616.git35bcf03.fc27.x86_64.rpm golang-github-billziss-gh-cgofuse-0-0.1.20170616.git35bcf03.fc27.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- golang-github-billziss-gh-cgofuse-devel (rpmlib, GLIBC filtered): golang-github-billziss-gh-cgofuse-unit-test-devel (rpmlib, GLIBC filtered): golang-github-billziss-gh-cgofuse-devel Provides -------- golang-github-billziss-gh-cgofuse-devel: golang(github.com/billziss-gh/cgofuse/examples/shared) golang(github.com/billziss-gh/cgofuse/fuse) golang-github-billziss-gh-cgofuse-devel golang-github-billziss-gh-cgofuse-unit-test-devel: golang-github-billziss-gh-cgofuse-unit-test-devel golang-github-billziss-gh-cgofuse-unit-test-devel(x86-64) Source checksums ---------------- https://github.com/billziss-gh/cgofuse/archive/35bcf037030dcadcd247618c75c00c6cd17482d7/cgofuse-35bcf03.tar.gz : CHECKSUM(SHA256) this package : 045a44e244a6d2c73544c27385aa2661726ed2227f8e3211a8687680b8af595c CHECKSUM(SHA256) upstream package : 045a44e244a6d2c73544c27385aa2661726ed2227f8e3211a8687680b8af595c
>Upstream does provide versions, have you considered using them? Ha good catch, I missed it. > If they are to be packaged, the files under examples directory should be under %doc Noted. SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591774-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591774-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse-1.0.2-1.fc27.src.rpm Thank for your reviews!
Hi Robert, Thanks for the fixes! Note that the -devel package is still providing the examples subpackages in the GOPATH: /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/hellofs /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/memfs /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/passthrough /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/shared /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/hellofs/hellofs.go /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/memfs/memfs.go /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/passthrough/passthrough.go /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/passthrough/port_darwin.go /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/passthrough/port_linux.go /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/shared/trace.go
I mean, if that is intentional, let me know and I will conclude the review!
It's not. Let's me fix that. SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-26-x86_64/00591841-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-26-x86_64/00591841-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse-1.0.2-1.fc26.src.rpm
Hi Robert, Sorry for the wait here. I will provide feedback on this bug ASAP. Note that the link for the latest SRPM is broken.
i'm away til Monday, so it's not super urgent but I was wondering if you hadn't forgotten. SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00599082-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00599082-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse-1.0.2-1.fc28.src.rpm
Hi Robert, On line 75 of the Spec file, there is a Provides for golang(%{import_path}/examples/shared), which was moved to the %doc path. This line should not be there anymore. I will trust you to remove that line before importing the package. Other than that, the package looks good. Approved.
OK, I didn't notice that. Thanks a lot.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-billziss-gh-cgofuse
golang-github-billziss-gh-cgofuse-1.0.2-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e0f30eb57
golang-github-billziss-gh-cgofuse-1.0.2-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b5cbe3f199
golang-github-billziss-gh-cgofuse-1.0.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-db023452bc
golang-github-billziss-gh-cgofuse-1.0.2-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e0f30eb57
golang-github-billziss-gh-cgofuse-1.0.2-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b5cbe3f199
golang-github-billziss-gh-cgofuse-1.0.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-db023452bc
golang-github-billziss-gh-cgofuse-1.0.2-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-billziss-gh-cgofuse-1.0.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-billziss-gh-cgofuse-1.0.2-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.