Bug 1475845 - novnc doesn't work
novnc doesn't work
Status: ON_QA
Product: ovirt-engine
Classification: oVirt
Component: Frontend.Core (Show other bugs)
future
Unspecified Unspecified
unspecified Severity high (vote)
: ovirt-4.2.0
: 4.2.0
Assigned To: bugs@ovirt.org
Liran Rotenberg
: Regression
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-27 09:09 EDT by jniederm
Modified: 2017-09-18 08:27 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: Virt
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rule-engine: ovirt‑4.2+
rule-engine: blocker+


Attachments (Terms of Use)
engine.log (4.73 KB, text/plain)
2017-07-27 09:09 EDT, jniederm
no flags Details
browser-console.log (1.64 KB, text/plain)
2017-07-27 09:10 EDT, jniederm
no flags Details


External Trackers
Tracker ID Priority Status Summary Last Updated
oVirt gerrit 80059 master MERGED core: novnc import of css and js fixed 2017-08-03 09:21 EDT

  None (edit)
Description jniederm 2017-07-27 09:09:14 EDT
Created attachment 1305360 [details]
engine.log

Description of problem:
Invoking noVNC console opens new tab with just a grey background.

It looks like the page tries to load resources that are no provided by current branding any more.

Version-Release number of selected component (if applicable):
4.2 master, commit 121657eb31

How reproducible:
100%

Steps to Reproduce:
1. Create a VM with VNC graphic protocol
2. Run the VM
3. Select novnc in Console Options dialog
4. Invoke Console of the VM

Actual results:
New browser tab pops up with just a grey page

Expected results:
working console

Additional info:
Comment 1 jniederm 2017-07-27 09:10 EDT
Created attachment 1305362 [details]
browser-console.log
Comment 2 jniederm 2017-07-31 09:23:44 EDT
It is failing because jQuery and other resources form package patternfly1 can't be found. Regression introduced by path https://gerrit.ovirt.org/#/c/61716/13/Makefile. Moving to UX.
Comment 3 Oved Ourfali 2017-07-31 09:34:32 EDT
Greg, can you take a look?
Comment 4 Greg Sheremeta 2017-08-01 08:14:45 EDT
Hi,

Those resources are still around, but they've moved. The paths to them probably shouldn't be hardcoded in novnc.jsp (and other console jsps).

see stylesheets.tag and javascripts.tag. You may want to try to use those, like the sso or welcome apps do.

New paths (as seen in right click view source of webadmin):

<link rel="stylesheet" type="text/css" href="/ovirt-engine/webadmin/theme/00-ovirt.brand/web_admin.css">
<link rel="stylesheet" type="text/css" href="/ovirt-engine/webadmin/theme/00-ovirt.brand/common.css">
<link rel="stylesheet" type="text/css" href="/ovirt-engine/webadmin/theme/00-ovirt.brand/gwt_common.css">
<link rel="stylesheet" type="text/css" href="/ovirt-engine/webadmin/theme/00-ovirt.brand/ovirt-js-dependencies/patternfly/dist/css/patternfly.min.css">
<link rel="stylesheet" type="text/css" href="/ovirt-engine/webadmin/theme/00-ovirt.brand/ovirt-js-dependencies/patternfly/dist/css/patternfly-additions.min.css">
<link rel="stylesheet" type="text/css" href="/ovirt-engine/webadmin/theme/00-ovirt.brand/patternfly-ovirt.css">
<link rel="stylesheet" type="text/css" href="/ovirt-engine/webadmin/theme/00-ovirt.brand/ovirt-patternfly-compat.css">
<link rel="stylesheet" type="text/css" href="/ovirt-engine/webadmin/theme/00-ovirt.brand/ovirt.css">
<script type="text/javascript" src="/ovirt-engine/webadmin/theme/00-ovirt.brand/ovirt-js-dependencies/jquery/dist/jquery.min.js"></script>
<script type="text/javascript" src="/ovirt-engine/webadmin/theme/00-ovirt.brand/ovirt-js-dependencies/jquery-ui-dist/jquery-ui.min.js"></script>
<script type="text/javascript" src="/ovirt-engine/webadmin/theme/00-ovirt.brand/ovirt-js-dependencies/bootstrap/dist/js/bootstrap.min.js"></script>
<script type="text/javascript" src="/ovirt-engine/webadmin/theme/00-ovirt.brand/patternfly-3.25.1-custom.min.js"></script>
<script type="text/javascript" src="/ovirt-engine/webadmin/theme/00-ovirt.brand/ovirt-js-dependencies/insertion-query/insQ.min.js"></script>
Comment 5 Red Hat Bugzilla Rules Engine 2017-08-01 10:07:13 EDT
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Note You need to log in before you can comment on or make changes to this bug.