Bug 1475861 - Download using FTPS makes wget abort
Summary: Download using FTPS makes wget abort
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: wget
Version: 32
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: aegorenk
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-27 13:35 UTC by Ondřej Lysoněk
Modified: 2020-07-03 10:08 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-07-02 06:57:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
trace (2.93 KB, text/plain)
2017-07-27 13:35 UTC, Ondřej Lysoněk
no flags Details

Description Ondřej Lysoněk 2017-07-27 13:35:02 UTC
Created attachment 1305372 [details]
trace

Description of problem:
When downloading a file over FTPS, wget aborts.

Version-Release number of selected component (if applicable):
wget-1.19.1-3.fc26.x86_64
vsftpd-3.0.3-5.fc26.x86_64

Steps to Reproduce:
cd /etc/vsftpd
# Modify the default vsftpd.conf
cat >> vsftpd.conf << EOF
ssl_enable=YES
allow_anon_ssl=YES
rsa_cert_file=/etc/vsftpd/a.crt
rsa_private_key_file=/etc/vsftpd/a.key
require_ssl_reuse=NO
EOF
openssl req -newkey rsa:2048 -nodes -keyout a.key -x509 -days 365 -out a.crt
cd /var/ftp/pub
echo test > test
systemctl restart vsftpd
cd
wget ftps://localhost/pub/test

Actual results:
wget aborts.

Expected results:
It shouldn't abort, should exit in a regular way.

Additional info:
The following works:
wget --no-check-certificate ftps://localhost/pub/test

Comment 1 Roman Žilka 2017-08-04 16:32:35 UTC
The SIGABRT occurs in the error-handling switch at src/ftp.c:1973. The getftp() call a few lines above it returns VERIFCERTERR because of the bad cert, but the switch doesn't handle that particular result and ends up abort()ing the process in the "default:" branch. If I append "case VERIFCERTERR:" to line 1975 (similarly to the way the situation is handled in src/http.c), no abnormal termination happens and wget exits with retcode 5.

Hopefully this saves someone a bit of debugging.

Referenced: vanilla wget-1.19.1, but everything is probably valid for 1.19.1-3.fc26 as well. The bug is also found in upstream git.

Comment 2 Fedora End Of Life 2018-05-03 08:33:57 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 3 Jan Kurik 2018-08-14 10:18:40 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.

Comment 4 Ben Cotton 2019-10-31 20:52:13 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Tomáš Hozza 2019-11-01 09:23:59 UTC
need to retest, but I think it is still an issue.

Comment 6 Ben Cotton 2020-02-11 15:45:43 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 7 aegorenk 2020-06-25 07:59:07 UTC
Patch sent to upstream:
https://lists.gnu.org/archive/html/bug-wget/2020-06/msg00026.html


Note You need to log in before you can comment on or make changes to this bug.