Created attachment 1305530 [details] screenshot: toolbar buttons - static / semi-dynamic IDs Description of problem: The IDs of all toolbar buttons in all main and detail views are not static anymore. The IDs now have a dynamic prefix, e.g., 'gwt-uid-337_New', but it should be 'MainTabDataCenterView_table_New'. See the screenshot attached. This has a great negative impact on our web UI automation. Version-Release number of selected component (if applicable): ovirt-engine-webadmin-portal-4.2.0-0.0.master.20170726123301.gitafc8eb1.el7.centos.noarch How reproducible: 100% Steps to Reproduce: 1. In Webadmin, go to Compute / Data Centers. 2. Inspect the New button widget with built-in developer tools, i.e., right-click on the button and select Inspect / Inspect Element (for Chrome / Firefox). 3. Check the 'id' attribute of the <button/> tag. Actual results: <button type="button" class="btn btn-default" id="gwt-uid-337_New">New</button> Expected results: <button type="button" class="btn btn-default" id="MainTabDataCenterView_table_New">New</button> Additional info: Data tables, dialogs and other widgets with static IDs are not affected. Regression against ovirt-engine-webadmin-portal-4.2.0-0.0.master.20170712143425.gitcb02bb5.el7.centos.noarch
This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
Marking it as a regression doesn't make sense. It isn't a broken feature.
Why this should not be a regression? A functionality for generating static IDs worked before but now is broken. Therefore it's a regression. Regressions are not applicable only to RFEs.
Regression comes to say a functionality of the product is now broken. The ids are an implementation detail. I understand it is important for automation, and Greg is assigned and will examine it, but it isn't a regression in terms of project functionality.
Created attachment 1307807 [details] fixed
Verified in ovirt-engine-webadmin-portal-4.2.0-0.0.master.20170903205106.gitb17261a.el7.centos.noarch IDs of the action buttons are now static again, although they are no longer unique. Buttons with the same label have the same ID, which can slightly complicate things, for example, when there are two buttons "Edit" present on the page at the same time.
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.