Red Hat Bugzilla – Bug 1476410
glusterd: code lacks clarity of logic in glusterd_get_quorum_cluster_counts()
Last modified: 2017-12-08 12:36:32 EST
This is counter-intuitive:
ret = gf_string2percent (val, &quorum_percentage);
ratio = _gf_true;
since !ret sounds like failure but ret == 0 signifies success here.
REVIEW: https://review.gluster.org/17912 (glusterd: improve intuitivity of check in glusterd_get_quorum_cluster_counts) posted (#1) for review on master by Michael Adam (firstname.lastname@example.org)
COMMIT: https://review.gluster.org/17912 committed in master by Atin Mukherjee (email@example.com)
Author: Michael Adam <firstname.lastname@example.org>
Date: Tue Jun 13 10:16:27 2017 +0200
glusterd: improve intuitivity of check in glusterd_get_quorum_cluster_counts
More intuitive to check for ret == 0 than !ret here...
Signed-off-by: Michael Adam <email@example.com>
Smoke: Gluster Build System <firstname.lastname@example.org>
Reviewed-by: Atin Mukherjee <email@example.com>
Tested-by: Atin Mukherjee <firstname.lastname@example.org>
CentOS-regression: Gluster Build System <email@example.com>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.
glusterfs-3.13.0 has been announced on the Gluster mailinglists , packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist  and the update infrastructure for your distribution.