Bug 1476560 - (deepin-desktop-schemas) Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas
Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Robert-André Mauchin
Fedora Extras Quality Assurance
Depends On:
Blocks: DeepinDEPackageReview deepin-metacity deepin-daemon
  Show dependency treegraph
Reported: 2017-07-30 06:26 EDT by sensor.wen
Modified: 2018-07-22 09:29 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2018-07-22 09:29:48 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
zebob.m: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Comment 2 Zbigniew Jędrzejewski-Szmek 2017-08-05 21:47:58 EDT
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

Ahh, deepin-artwork-themes. I don't think you submitted that for review yet.

- glib-compile-schemas is run in %postun and %posttrans if package has
  *.gschema.xml files.
  Note: gschema file(s) in deepin-desktop-schemas
Comment 3 sensor.wen 2017-08-06 16:41:00 EDT
SPEC:  https://raw.githubusercontent.com/FZUG/repo/5e57f37830e634919c2c440cf8a5fb2311ca2e7e/rpms/deepin_project/deepin-desktop-schemas.spec

Fixed :)
I will be submit deepin-artwork-themes package for review.
Comment 4 Zbigniew Jędrzejewski-Szmek 2017-08-06 21:46:12 EDT
Oops, sorry. My comment about glib-compile-schemas was wrong. I trusted fedora-review without checking the guidelines, but /usr/bin/glib-compile-schemas should not be called since F24 (#1409315). So please remove those calls again.

Looks good otherwise, I'll re-review when deepin-artwork-themes review is done.
Comment 5 sensor.wen 2017-08-07 03:07:08 EDT
Diff:  https://github.com/FZUG/repo/commit/260e289c3ff55635f076bcf3992895a0d338a1c6

Ok, thanks :)  It deleted.
Comment 6 Robert-André Mauchin 2017-08-25 05:23:30 EDT
Have you proposed deepin-artwork-themes and deepin-gtk-theme yet?
Comment 7 Robert-André Mauchin 2017-08-25 17:41:22 EDT
@mosquito: There's a new release, 3.1.16 See https://github.com/linuxdeepin/deepin-desktop-schemas/releases

Once you bump the version, I'll accept the package.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v3 or later)", "Unknown or generated". 105 files have
     unknown license. Detailed output of licensecheck in
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: deepin-desktop-schemas-3.1.15-1.fc28.noarch.rpm
deepin-desktop-schemas.noarch: W: spelling-error Summary(en_US) GSettings -> G Settings, Settings, Insetting
deepin-desktop-schemas.noarch: W: spelling-error %description -l en_US GSettings -> G Settings, Settings, Insetting
deepin-desktop-schemas.src: W: spelling-error Summary(en_US) GSettings -> G Settings, Settings, Insetting
deepin-desktop-schemas.src: W: spelling-error %description -l en_US GSettings -> G Settings, Settings, Insetting
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Comment 9 Robert-André Mauchin 2017-08-26 03:09:25 EDT
Perfect, package accepted.
Comment 10 Gwyn Ciesla 2017-08-28 07:15:52 EDT
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-desktop-schemas
Comment 11 Fedora Update System 2017-10-09 10:47:12 EDT
deepin-desktop-schemas-3.1.16-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-198295a453
Comment 12 Fedora Update System 2017-10-11 02:26:39 EDT
deepin-desktop-schemas-3.1.16-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-198295a453
Comment 13 Zamir SUN 2018-07-22 09:29:48 EDT
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.

Note You need to log in before you can comment on or make changes to this bug.