RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1476664 - ss filter parsing bug causes crash
Summary: ss filter parsing bug causes crash
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: iproute
Version: 6.9
Hardware: All
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Phil Sutter
QA Contact: Jaroslav Aster
Ioanna Gkioka
URL:
Whiteboard:
Depends On:
Blocks: 1506394
TreeView+ depends on / blocked
 
Reported: 2017-07-31 06:43 UTC by Martin Schwenke
Modified: 2018-06-19 05:11 UTC (History)
10 users (show)

Fixed In Version: iproute-2.6.32-57.el6
Doc Type: Bug Fix
Doc Text:
The `ss` program no longer stops when providing a long list of filters Previously, providing a long list of filters to the "ss" command caused an integer value overflow. As a consequence, the 'ss' tool could stop the program execution. With this update, faulty bits in the source code are corrected, and the described problem no longer occurs.
Clone Of:
Environment:
Last Closed: 2018-06-19 05:10:41 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Debian BTS 511720 0 None None None 2017-07-31 06:43:26 UTC
Red Hat Product Errata RHBA-2018:1867 0 None None None 2018-06-19 05:11:00 UTC

Description Martin Schwenke 2017-07-31 06:43:27 UTC
Description of problem:

ss crashes when the filter is too long/complex

Version-Release number of selected component (if applicable):

iproute-2.6.32-54.el6.x86_64

How reproducible:

Very reliable

Steps to Reproduce:

1. valgrind -q ss -tn state established 'src 10.0.0.31:22 || src 10.0.0.32:22 || src 10.0.0.33:22 || src 10.0.0.34:22 || src 10.0.0.35:22 || src 10.0.0.36:22 || src 10.0.0.37:22 || src 10.0.0.38:22'  

Actual results:

  Recv-Q Send-Q    Local Address:Port      Peer Address:Port 
  ==4372== Warning: silly arg (-100) to malloc()
  Aborted (core dumped)

Expected results:

  A possibly empty list of connections.  valgrind still complains but it is at least non-fatal.

Additional info:

This can obviously be recreated without valgrind.  However, valgrind points out the nature of the problem.

The problem is that the following upstream commit is missing:

commit 2a4fa1c305742e4bfbc2960c40e0d1ee55b30694
Author: Andreas Henriksson <andreas>
Date:   Wed Nov 13 09:46:42 2013 +0100

    ss: avoid passing negative numbers to malloc
    
    Example:
    
    $ ss state established \( sport = :4060  or sport = :4061 or sport = :4062  or sport = :4063 or sport = :4064  or sport = :4065 or sport = :4066  or sport = :4067 \)  > /dev/null
    Aborted
    
    In the example above ssfilter_bytecompile(...) will return (int)136.
    char l1 = 136; means -120 which will result in a negative number
    being passed to malloc at misc/ss.c:913.
    
    Simply declare l1 and l2 as integers to avoid the char overflow.
    
    This is one of the issues originally reported in http://bugs.debian.org/511720
    
    Fix the same problem in other code paths as well (thanks to Eric Dumazet).
    
    Reported-by: Andreas Schuldei <andreas>
    Signed-off-by: Andreas Henriksson <andreas>
    Reviewed-by: Eric Dumazet <edumazet>

Comment 15 errata-xmlrpc 2018-06-19 05:10:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:1867


Note You need to log in before you can comment on or make changes to this bug.