Bug 1476668 - [Disperse] : Improve heal info command to handle obvious cases
[Disperse] : Improve heal info command to handle obvious cases
Status: MODIFIED
Product: GlusterFS
Classification: Community
Component: disperse (Show other bugs)
mainline
Unspecified Unspecified
high Severity medium
: ---
: ---
Assigned To: Ashish Pandey
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-31 02:53 EDT by Ashish Pandey
Modified: 2017-10-15 22:47 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Ashish Pandey 2017-07-31 02:53:41 EDT
Description of problem:

If an update fop (data) is going on for a file, its index entry will be present in .glustrfs/indeices.
Now, If a brick is down and we run heal info on EC volume, it is obvious that this file needs heal. There is no need of taking lock and slowing down heal info command.



Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Worker Ant 2017-07-31 03:44:23 EDT
REVIEW: https://review.gluster.org/17923 (cluster/ec: Improve heal info command to handle obvious cases) posted (#1) for review on master by Ashish Pandey (aspandey@redhat.com)
Comment 2 Worker Ant 2017-10-09 13:20:42 EDT
REVIEW: https://review.gluster.org/17923 (cluster/ec: Improve heal info command to handle obvious cases) posted (#2) for review on master by Ashish Pandey (aspandey@redhat.com)
Comment 3 Worker Ant 2017-10-11 06:27:54 EDT
REVIEW: https://review.gluster.org/17923 (cluster/ec: Improve heal info command to handle obvious cases) posted (#3) for review on master by Ashish Pandey (aspandey@redhat.com)
Comment 4 Worker Ant 2017-10-15 22:40:05 EDT
COMMIT: https://review.gluster.org/17923 committed in master by Pranith Kumar Karampuri (pkarampu@redhat.com) 
------
commit d88be3bc29dbd1eaa393802f3c98e188fe5287c8
Author: Ashish Pandey <aspandey@redhat.com>
Date:   Mon Jul 31 12:45:21 2017 +0530

    cluster/ec: Improve heal info command to handle obvious cases
    
    Problem:
    1 - If a brick is down and we see an index entry in
    .glusterfs/indices, we should show it in heal info
    output as it most certainly needs heal.
    
    2 - The first problem is also not getting handled after
    ec_heal_inspect. Even if in ec_heal_inspect, lookup will
    mark need_heal as true, we don't handle it properly in
    ec_get_heal_info and continue with locked inspect which
    takes lot of time.
    
    Solution:
    1 - In first case we need not to do any further invstigation.
    As soon as we see that a brick is down, we should say that
    this index entry needs heal for sure.
    
    2 - In second case, if we have need_heal as _gf_true after
    ec_heal_inspect, we should show it as heal requires.
    
    Change-Id: Ibe7f9d7602cc0b382ba53bddaf75a2a2c3326aa6
    BUG: 1476668
    Signed-off-by: Ashish Pandey <aspandey@redhat.com>

Note You need to log in before you can comment on or make changes to this bug.