glusterd_validate_quorum performs unnecessary operations when the volume is not of server-quorum type "server". This could be optimized.
REVIEW: https://review.gluster.org/17924 (glusterd: streamline logic flow in glusterd_validate_quorum()) posted (#1) for review on master by Michael Adam (obnox)
COMMIT: https://review.gluster.org/17924 committed in master by Atin Mukherjee (amukherj) ------ commit 3023c4bd7651d4503830c36676cd08864e315cdf Author: Michael Adam <obnox> Date: Tue Jun 13 14:44:39 2017 +0200 glusterd: streamline logic flow in glusterd_validate_quorum() Make an earlier exit when the volume is not of server quorum. Thereby it spares the actual quorum calculation in this case. This also increases the overall readability of the function. The patch is best seen with the --patience diff option to understand what it does (e.g. "git show --patience"). Change-Id: Ifce50bc3f73d79d3d6226473661a83696d65149a BUG: 1476719 Signed-off-by: Michael Adam <obnox> Reviewed-on: https://review.gluster.org/17924 Smoke: Gluster Build System <jenkins.org> Tested-by: Atin Mukherjee <amukherj> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Amar Tumballi <amarts> Reviewed-by: Atin Mukherjee <amukherj>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report. glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html [2] https://www.gluster.org/pipermail/gluster-users/