Bug 1476892 - tmux update in F26 broke tmuxinator
Summary: tmux update in F26 broke tmuxinator
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: tmux
Version: 27
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Filipe Rosset
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-31 17:58 UTC by Filipe Rosset
Modified: 2017-08-20 18:25 UTC (History)
6 users (show)

Fixed In Version: tmux-2.5-4.fc26
Clone Of:
Environment:
Last Closed: 2017-08-20 18:25:09 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch file for tmux 2.5 from tmux GH issue (537 bytes, patch)
2017-07-31 18:47 UTC, Leonid Podolny
no flags Details | Diff

Description Filipe Rosset 2017-07-31 17:58:37 UTC
A recent tmux update in F26 broke tmuxinator for me. Upstream tmux fixed the bug, but the fix will be released in 2.6. I wanted to avoid being stuck with 2.3, so I backported the (very short) patch and applied it against tmux-2.5. I verified that it works.

double check:
--- tmux.spec.orig	2017-07-31 11:09:39.401580626 -0400
+++ tmux.spec	2017-07-31 11:18:16.000000000 -0400
@@ -1,6 +1,6 @@
 Name:           tmux
 Version:        2.5
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        A terminal multiplexer
 
 Group:          Applications/System
@@ -13,6 +13,12 @@
 # Examples has been removed - so include the bash_completion here
 Source1:        bash_completion_tmux.sh
 
+# tmuxinator wouldn't start with tmux 2.5
+# tmuxinator discussion: https://github.com/tmuxinator/tmuxinator/issues/536
+# tmux discussion (states that the patch won't be backported to 2.5):
+#  https://github.com/tmux/tmux/issues/971  
+Patch0:         tmux-2.5-fail-on-no-target.diff
+
 BuildRequires:  ncurses-devel
 BuildRequires:  libevent-devel
 BuildRequires:  libutempter-devel
@@ -24,7 +30,7 @@
 as GNU Screen.
 
 %prep
-%setup -q
+%autosetup
 
 %build
 CFLAGS="$RPM_OPT_FLAGS -fPIC -pie -Wl,-z,relro -Wl,-z,now"

Comment 1 Leonid Podolny 2017-07-31 18:47:42 UTC
Created attachment 1307216 [details]
Patch file for tmux 2.5 from tmux GH issue

Comment 2 Leonid Podolny 2017-07-31 18:48:56 UTC
Added the .patch file that the .spec file refers to as an attachment

Comment 3 Fedora Update System 2017-08-05 18:11:38 UTC
tmux-2.5-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-762848d530

Comment 4 Fedora Update System 2017-08-07 06:25:29 UTC
tmux-2.5-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-762848d530

Comment 5 Jan Kurik 2017-08-15 09:17:21 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle.
Changing version to '27'.

Comment 6 Fedora Update System 2017-08-20 18:25:09 UTC
tmux-2.5-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.