Bug 1476957 - peer-parsing.t fails on NetBSD
peer-parsing.t fails on NetBSD
Status: NEW
Product: GlusterFS
Classification: Community
Component: tests (Show other bugs)
mainline
Unspecified NetBSD
unspecified Severity unspecified
: ---
: ---
Assigned To: bugs@gluster.org
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-31 19:35 EDT by Csaba Henk
Modified: 2017-08-02 16:56 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Csaba Henk 2017-07-31 19:35:21 EDT
Description of problem:

$ uname -a
NetBSD bab 7.0.2 NetBSD 7.0.2 (GENERIC.201610210724Z) i386
$ sudo env DEBUG=1 ./run-tests.sh ./tests/basic/peer-parsing.t

... GlusterFS Test Framework ...

/mnt/scratch/glusterfs /mnt/scratch/glusterfs
/mnt/scratch/glusterfs

================================================================================
[23:30:28] Running tests in file ./tests/basic/peer-parsing.t
./tests/basic/peer-parsing.t ..
1..8
=========================
TEST 1 (line 6): mkdir -p /var/lib/glusterd/peers
ok 1, LINENUM:6
RESULT 1: 0
=========================
TEST 2 (line 36): create_random_peer_files
ok 2, LINENUM:36
RESULT 2: 0
=========================
TEST 3 (line 37): create_non_peer_file
ok 3, LINENUM:37
RESULT 3: 0
=========================
TEST 4 (line 38): create_random_peer_files
ok 4, LINENUM:38
RESULT 4: 0
=========================
TEST 5 (line 39): create_malformed_peer_file
ok 5, LINENUM:39
RESULT 5: 0
=========================
TEST 6 (line 40): create_random_peer_files
ok 6, LINENUM:40
RESULT 6: 0
=========================
TEST 7 (line 43): glusterd
ok 7, LINENUM:43
RESULT 7: 0
=========================
TEST 8 (line 45): [ 0 = 30 ]
not ok 8 , LINENUM:45
RESULT 8: 1
Failed 1/8 subtests

Test Summary Report
-------------------
./tests/basic/peer-parsing.t (Wstat: 0 Tests: 8 Failed: 1)
  Failed test:  8
Files=1, Tests=8, 21 wallclock secs ( 0.04 usr  0.04 sys +  1.50 cusr  3.31 csys =  4.89 CPU)
Result: FAIL
./tests/basic/peer-parsing.t: bad status 1

       *********************************
       *       REGRESSION FAILED       *
       * Retrying failed tests in case *
       * we got some spurious failures *
       *********************************

./tests/basic/peer-parsing.t ..
1..8
=========================
TEST 1 (line 6): mkdir -p /var/lib/glusterd/peers
ok 1, LINENUM:6
RESULT 1: 0
=========================
TEST 2 (line 36): create_random_peer_files
ok 2, LINENUM:36
RESULT 2: 0
=========================
TEST 3 (line 37): create_non_peer_file
ok 3, LINENUM:37
RESULT 3: 0
=========================
TEST 4 (line 38): create_random_peer_files
ok 4, LINENUM:38
RESULT 4: 0
=========================
TEST 5 (line 39): create_malformed_peer_file
ok 5, LINENUM:39
RESULT 5: 0
=========================
TEST 6 (line 40): create_random_peer_files
ok 6, LINENUM:40
RESULT 6: 0
=========================
TEST 7 (line 43): glusterd
ok 7, LINENUM:43
RESULT 7: 0
=========================
TEST 8 (line 45): [ 0 = 30 ]
not ok 8 , LINENUM:45
RESULT 8: 1
Failed 1/8 subtests

Test Summary Report
-------------------
./tests/basic/peer-parsing.t (Wstat: 0 Tests: 8 Failed: 1)
  Failed test:  8
Files=1, Tests=8, 21 wallclock secs ( 0.07 usr  0.02 sys +  1.71 cusr  3.03 csys =  4.83 CPU)
Result: FAIL
End of test ./tests/basic/peer-parsing.t
================================================================================


Run complete
================================================================================
Number of tests found:                             118
Number of tests selected for run based on pattern: 1
Number of tests skipped as they were marked bad:   0
Number of tests skipped because of known_issues:   0
Number of tests that were run:                     1

Tests ordered by time taken, slowest to fastest:
================================================================================
./tests/basic/peer-parsing.t  -  21 second

1 test(s) failed
./tests/basic/peer-parsing.t

0 test(s) generated core


Result is 1
Comment 1 Worker Ant 2017-07-31 19:40:21 EDT
REVIEW: https://review.gluster.org/17937 (tests: fix hardcoded path in basic/peer-parsing.t) posted (#1) for review on master by Csaba Henk (csaba@redhat.com)
Comment 2 Worker Ant 2017-07-31 20:39:09 EDT
REVIEW: https://review.gluster.org/17937 (tests: don't use hard coded values for glusterd workdir) posted (#2) for review on master by Csaba Henk (csaba@redhat.com)
Comment 3 Worker Ant 2017-07-31 20:39:38 EDT
REVIEW: https://review.gluster.org/17937 (tests: don't use hard coded value for glusterd workdir) posted (#3) for review on master by Csaba Henk (csaba@redhat.com)
Comment 4 Worker Ant 2017-08-02 16:56:21 EDT
COMMIT: https://review.gluster.org/17937 committed in master by Jeff Darcy (jeff@pl.atyp.us) 
------
commit c7e5741f938e24b85976bf78ea7d84984a4e1e61
Author: Csaba Henk <csaba@redhat.com>
Date:   Tue Aug 1 01:38:00 2017 +0200

    tests: don't use hard coded value for glusterd workdir
    
    A number of test referred to /var/lib/glusterd,
    they were adjusted to use "$GLUSTERD_WORKDIR".
    
    (This has significance for proper test runs on non-Linux
    platforms -- see the following #define in glusterfs.h:
    
      #ifdef GF_LINUX_HOST_OS
      #define GLUSTERD_DEFAULT_WORKDIR DATADIR "/lib/glusterd"
      #else
      #define GLUSTERD_DEFAULT_WORKDIR DATADIR "/db/glusterd"
      #endif
    
    Ie. the glusterd workdir will typically be /var/db/glusterd
    instead of /var/lib/glusterd on non-Linux platforms.)
    
    BUG: 1476957
    Change-Id: I69ce3e1bb7a0c14ea85b60adbf8205f9aca46cd5
    Signed-off-by: Csaba Henk <csaba@redhat.com>
    Reviewed-on: https://review.gluster.org/17937
    Smoke: Gluster Build System <jenkins@build.gluster.org>
    Reviewed-by: Amar Tumballi <amarts@redhat.com>
    Tested-by: Amar Tumballi <amarts@redhat.com>
    CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
    Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>

Note You need to log in before you can comment on or make changes to this bug.