Red Hat Bugzilla – Bug 1477377
Backport: net/i40e/base: fix unknown PHYs incorrect identification
Last modified: 2018-05-17 09:35:18 EDT
Description of problem:
Version-Release number of selected component (if applicable):
OVS 2.6.1 with DPDK 16.11
Steps to Reproduce:
Here’s a DPDK patch (”net/i40e/base: fix unknown PHYs incorrect identification”)
that was submitted on 2016-12-10, too late for DPDK 16.11:
The description states:
The PHY type value for unrecognized PHYs and cables was changed
based on firmware version number. Newer hardware use lower firmware
version numbers and this was causing some PHYs to be identified
as type 0x16 instead of 0xe (unknown).
Without this patch, newer card will incorrectly identify unknown
PHYs and cables.
This change adds hardware type to the check for firmware version
so the PHY type is reported correctly.
This change does not appear to have been backported to DPDK 16.11.2.
Created attachment 1308865 [details]
rpm for ovs with backported patch for testing
Hi Andreas, this patch was not backported DPDK 16.11 stable branch as it is a modification to the i40e base driver, which is generally a drag'n'drop into DPDK from the Intel i40e driver team.
DPDK try to avoid making any changes to this code directly in upstream master DPDK, but occasionally it does it happen. However, they tend to not backport to older DPDK as the base driver is sensitive to firmware versions which may have changed. So what is safe today, might not be safe in an older release.
It's not clear without knowing about operation of the firmware whether this is ok for DPDK 16.11 or not.
The customer case is closed now. Do you think this still needs to be backported? If so, I would contact Intel to ask them about it's suitability for DPDK 16.11.
The related case was indeed fixed by openvswitch-2.6.1-16 and hence by a different fix. I am going to relay this info to the customer. Do you know if there are potentially any negative consequences of not backporting that fix? Seems to have to do with link detection, however I don't remember the exact context of this.
This will be part of openvswitch-2.9.X releases which use DPDK 17.11.