RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1477745 - Emacs GUI Toolbar icons missing
Summary: Emacs GUI Toolbar icons missing
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: emacs
Version: 7.4
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Jan Synacek
QA Contact: Frantisek Sumsal
URL:
Whiteboard:
: 1495264 (view as bug list)
Depends On:
Blocks: 1484996 1549617 1549689 1551061
TreeView+ depends on / blocked
 
Reported: 2017-08-02 19:33 UTC by Don Pellegrino
Modified: 2021-12-10 15:11 UTC (History)
23 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-30 10:45:11 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Screenshot (28.98 KB, image/png)
2017-08-02 19:33 UTC, Don Pellegrino
no flags Details
patch (30.37 KB, patch)
2018-01-04 08:22 UTC, Jan Synacek
no flags Details | Diff
patch v2 (25.51 KB, patch)
2018-01-05 14:01 UTC, Jan Synacek
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1495264 0 medium CLOSED Missing icons in emacs 2021-12-10 15:17:20 UTC
Red Hat Knowledge Base (Solution) 3685831 0 None None None 2018-11-12 17:36:28 UTC
Red Hat Product Errata RHBA-2018:3166 0 None None None 2018-10-30 10:45:28 UTC

Internal Links: 1495264

Description Don Pellegrino 2017-08-02 19:33:49 UTC
Created attachment 1308433 [details]
Screenshot

Description of problem:

The Emacs GUI toolbar icons disappeared after the RHEL 7.3 to 7.4 upgrade set.

Version-Release number of selected component (if applicable):

$ rpm -qi emacs
Name        : emacs
Epoch       : 1
Version     : 24.3
Release     : 19.el7_3
Architecture: x86_64
Install Date: Fri 03 Mar 2017 01:50:25 PM EST
Group       : Applications/Editors
Size        : 14848179
License     : GPLv3+
Signature   : RSA/SHA256, Thu 09 Feb 2017 11:30:33 AM EST, Key ID 199e2f91fd431d51
Source RPM  : emacs-24.3-19.el7_3.src.rpm
Build Date  : Mon 16 Jan 2017 06:14:36 AM EST
Build Host  : x86-037.build.eng.bos.redhat.com
Relocations : (not relocatable)
Packager    : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla>
Vendor      : Red Hat, Inc.
URL         : http://www.gnu.org/software/emacs/
Summary     : GNU Emacs text editor
Description :
Emacs is a powerful, customizable, self-documenting, modeless text
editor. Emacs contains special code editing features, a scripting
language (elisp), and the capability to read mail, news, and more
without leaving the editor.

This package provides an emacs binary with support for X windows.

How reproducible:

Always

Actual results:

See screenshot

Additional info:

It seems that after the upgrade from RHEL 7.3 to 7.4 and a reboot, the Emacs GUI lost its toolbar icons. Note that the emacs package is still reported as el7_3. Perhaps there is a 7.4 package missing from the repository?

Comment 2 Jan Synacek 2017-08-03 07:11:35 UTC
(In reply to Donald Pellegrino from comment #0)
> It seems that after the upgrade from RHEL 7.3 to 7.4 and a reboot, the Emacs
> GUI lost its toolbar icons.

There were only 2 tiny fixes going into Emacs for 7.4 that had nothing to do with GUI. I have verified that the icons are missing even with emacs-24.3-18.el7.x86_64. The problem is very likely in the gtk code that has changed quite a lot with the update.

> Note that the emacs package is still reported as
> el7_3. Perhaps there is a 7.4 package missing from the repository?

This is expected. The el7_3 means that the patches I wrote about above were also applied in 7.3.z (z-stream) and no newer fixes were added into 7.4.

Comment 3 Don Pellegrino 2017-08-03 14:41:03 UTC
Thanks for the heads-up @Jan Synacek. This is a minor issue, but if bumping the whole package up to the latest GNU Emacs 25.2 fixes things then that would be ideal fix for me.

Comment 4 andrew2.hart 2017-09-21 11:57:39 UTC
Compiling emacs 25.2.1 from source fixed this emacs toolbar icons / buttons missing problem for me (as did downgrading everything gtk 3.22)

Comment 5 andrew2.hart 2017-09-21 12:51:26 UTC
I am thinking it is to be fixed is emacs not gtk ... but i am no-one :

https://bugs.archlinux.org/task/48862

Comment 6 Matthias Clasen 2017-11-10 20:31:26 UTC
https://github.com/emacs-mirror/emacs/commit/3f4c6d52d345999938bc2d4a53246af4c61ef176

is an emacs commit that is supposed to fix this

Comment 8 Matthias Clasen 2018-01-02 17:50:35 UTC
Jan, can you do that ?

Comment 9 Jan Synacek 2018-01-03 08:32:29 UTC
17 out of 31 hunks FAILED -- saving rejects to file src/gtkutil.c.rej

This may take a while.

Comment 11 Jan Synacek 2018-01-04 08:22:06 UTC
Created attachment 1376690 [details]
patch

Comment 16 Jan Synacek 2018-01-05 14:01:55 UTC
Created attachment 1377500 [details]
patch v2

Comment 17 Jan Synacek 2018-01-05 14:05:21 UTC
Note that this patch also removes the tear-off handles from the menu bar. That is how it was written upstream and I don't consider it a regression. I also tried to backport only the icon-related parts of the patch without touching the menu bar handles, but that didn't work at all.

Comment 18 Wendell MacKenzie 2018-01-19 19:23:44 UTC
I applied this patch to my 24.3 src download, rebuilt and installed it.  Toolbar is back again. :)

Comment 19 Jan Synacek 2018-01-22 07:26:30 UTC
Thank you for testing!

Comment 20 BugMasta 2018-03-16 03:59:02 UTC
Geezus christ. Enterprise Linux. And emacs is broken.

This is a travesty.

Comment 21 Jan Synacek 2018-04-09 09:01:53 UTC
*** Bug 1495264 has been marked as a duplicate of this bug. ***

Comment 29 Paul Weber 2018-08-02 18:16:44 UTC
We can forcibly remove the updated (latest) version of gtk3-3.22.26-4.el7_5.x86_64 and subsequently force the installation of gtk3-3.14.13-16.el7.x86_64 via the rpm command.  The icons return to the menu of emacs-24.3-20.el7_4.x86_64.  The issue appears to be in gtk3 after gtk3-3.14.13-16.el7

Comment 30 Frantisek Sumsal 2018-09-06 09:17:07 UTC
Created attachment 1481240 [details]
Old emacs version with missing icons

Comment 31 Frantisek Sumsal 2018-09-06 09:17:41 UTC
Created attachment 1481241 [details]
New emacs version with icons present

Comment 33 vicgonzalez 2018-10-05 12:45:20 UTC
(In reply to Frantisek Sumsal from comment #31)
> Created attachment 1481241 [details]
> New emacs version with icons present

I tried to follow the attachment link but I get a "Sorry, you are not authorized to access attachment" error...
How can I get it?

Comment 34 Jan Synacek 2018-10-05 13:02:41 UTC
(In reply to vicgonzalez from comment #33)
> How can I get it?

You can't, they are private. They just show that the icons are back.

Comment 35 vicgonzalez 2018-10-05 14:35:49 UTC
(In reply to Jan Synacek from comment #34)
> (In reply to vicgonzalez from comment #33)
> > How can I get it?
> 
> You can't, they are private. They just show that the icons are back.

And where or when will be a binary version with the fix to download?
The trick downgrading gtk3 has lots of dependencies...

Comment 36 Frantisek Sumsal 2018-10-08 08:22:11 UTC
(In reply to vicgonzalez from comment #35)
> (In reply to Jan Synacek from comment #34)
> > (In reply to vicgonzalez from comment #33)
> > > How can I get it?
> > 
> > You can't, they are private. They just show that the icons are back.
> 
> And where or when will be a binary version with the fix to download?
> The trick downgrading gtk3 has lots of dependencies...

The fix is included in RHEL 7.6, so it will be available when 7.6 reaches GA.

Comment 37 vicgonzalez 2018-10-09 12:36:53 UTC
Great! I downloaded the 7.6beta and then in a RHEL 7.4 upgraded all the emacs packages and its dependencies (240 all together) to the 7.6beta equivalent.
Now the icons work perfectly. 
The packages were basically:
 dbus-1.10.24-11.el7.x86_64.rpm
 dbus-devel-1.10.24-11.el7.x86_64.rpm
 dbus-libs-1.10.24-11.el7.x86_64.rpm
 dbus-x11-1.10.24-11.el7.x86_64.rpm
 emacs-24.3-21.el7.x86_64.rpm
 emacs-auctex-11.87-4.el7.noarch.rpm
 emacs-common-24.3-21.el7.x86_64.rpm
 emacs-filesystem-24.3-21.el7.noarch.rpm
 emacs-gnuplot-4.6.2-3.el7.noarch.rpm
 emacs-nox-24.3-21.el7.x86_64.rpm
 emacs-php-mode-1.18.2-1.el7.noarch.rpm
 t1lib-5.1.2-14.el7.x86_64.rpm
 tex-preview-11.87-4.el7.noarch.rpm
 texlive-2012-43.20130427_r30134.el7.x86_64.rpm
 texlive-ae-svn15878.1.4-43.el7.noarch.rpm
 texlive-algorithms-svn15878.0.1-43.el7.noarch.rpm
and lots of other texlive-

Comment 39 errata-xmlrpc 2018-10-30 10:45:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3166


Note You need to log in before you can comment on or make changes to this bug.