Bug 1477745 - Emacs GUI Toolbar icons missing
Emacs GUI Toolbar icons missing
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: emacs (Show other bugs)
x86_64 Linux
medium Severity medium
: rc
: ---
Assigned To: Jan Synacek
BaseOS QE Security Team
: 1495264 (view as bug list)
Depends On:
Blocks: 1432486 1549617 1549689 1551061
  Show dependency treegraph
Reported: 2017-08-02 15:33 EDT by Don Pellegrino
Modified: 2018-04-09 05:01 EDT (History)
15 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Screenshot (28.98 KB, image/png)
2017-08-02 15:33 EDT, Don Pellegrino
no flags Details
patch (30.37 KB, patch)
2018-01-04 03:22 EST, Jan Synacek
no flags Details | Diff
patch v2 (25.51 KB, patch)
2018-01-05 09:01 EST, Jan Synacek
no flags Details | Diff

  None (edit)
Description Don Pellegrino 2017-08-02 15:33:49 EDT
Created attachment 1308433 [details]

Description of problem:

The Emacs GUI toolbar icons disappeared after the RHEL 7.3 to 7.4 upgrade set.

Version-Release number of selected component (if applicable):

$ rpm -qi emacs
Name        : emacs
Epoch       : 1
Version     : 24.3
Release     : 19.el7_3
Architecture: x86_64
Install Date: Fri 03 Mar 2017 01:50:25 PM EST
Group       : Applications/Editors
Size        : 14848179
License     : GPLv3+
Signature   : RSA/SHA256, Thu 09 Feb 2017 11:30:33 AM EST, Key ID 199e2f91fd431d51
Source RPM  : emacs-24.3-19.el7_3.src.rpm
Build Date  : Mon 16 Jan 2017 06:14:36 AM EST
Build Host  : x86-037.build.eng.bos.redhat.com
Relocations : (not relocatable)
Packager    : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla>
Vendor      : Red Hat, Inc.
URL         : http://www.gnu.org/software/emacs/
Summary     : GNU Emacs text editor
Description :
Emacs is a powerful, customizable, self-documenting, modeless text
editor. Emacs contains special code editing features, a scripting
language (elisp), and the capability to read mail, news, and more
without leaving the editor.

This package provides an emacs binary with support for X windows.

How reproducible:


Actual results:

See screenshot

Additional info:

It seems that after the upgrade from RHEL 7.3 to 7.4 and a reboot, the Emacs GUI lost its toolbar icons. Note that the emacs package is still reported as el7_3. Perhaps there is a 7.4 package missing from the repository?
Comment 2 Jan Synacek 2017-08-03 03:11:35 EDT
(In reply to Donald Pellegrino from comment #0)
> It seems that after the upgrade from RHEL 7.3 to 7.4 and a reboot, the Emacs
> GUI lost its toolbar icons.

There were only 2 tiny fixes going into Emacs for 7.4 that had nothing to do with GUI. I have verified that the icons are missing even with emacs-24.3-18.el7.x86_64. The problem is very likely in the gtk code that has changed quite a lot with the update.

> Note that the emacs package is still reported as
> el7_3. Perhaps there is a 7.4 package missing from the repository?

This is expected. The el7_3 means that the patches I wrote about above were also applied in 7.3.z (z-stream) and no newer fixes were added into 7.4.
Comment 3 Don Pellegrino 2017-08-03 10:41:03 EDT
Thanks for the heads-up @Jan Synacek. This is a minor issue, but if bumping the whole package up to the latest GNU Emacs 25.2 fixes things then that would be ideal fix for me.
Comment 4 andrew2.hart 2017-09-21 07:57:39 EDT
Compiling emacs 25.2.1 from source fixed this emacs toolbar icons / buttons missing problem for me (as did downgrading everything gtk 3.22)
Comment 5 andrew2.hart 2017-09-21 08:51:26 EDT
I am thinking it is to be fixed is emacs not gtk ... but i am no-one :

Comment 6 Matthias Clasen 2017-11-10 15:31:26 EST

is an emacs commit that is supposed to fix this
Comment 8 Matthias Clasen 2018-01-02 12:50:35 EST
Jan, can you do that ?
Comment 9 Jan Synacek 2018-01-03 03:32:29 EST
17 out of 31 hunks FAILED -- saving rejects to file src/gtkutil.c.rej

This may take a while.
Comment 11 Jan Synacek 2018-01-04 03:22 EST
Created attachment 1376690 [details]
Comment 16 Jan Synacek 2018-01-05 09:01 EST
Created attachment 1377500 [details]
patch v2
Comment 17 Jan Synacek 2018-01-05 09:05:21 EST
Note that this patch also removes the tear-off handles from the menu bar. That is how it was written upstream and I don't consider it a regression. I also tried to backport only the icon-related parts of the patch without touching the menu bar handles, but that didn't work at all.
Comment 18 Wendell MacKenzie 2018-01-19 14:23:44 EST
I applied this patch to my 24.3 src download, rebuilt and installed it.  Toolbar is back again. :)
Comment 19 Jan Synacek 2018-01-22 02:26:30 EST
Thank you for testing!
Comment 20 BugMasta 2018-03-15 23:59:02 EDT
Geezus christ. Enterprise Linux. And emacs is broken.

This is a travesty.
Comment 21 Jan Synacek 2018-04-09 05:01:53 EDT
*** Bug 1495264 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.