Bug 1477907

*** Bug 1477883 has been marked as a duplicate of this bug. ***

The fix here is two-part:

1. Add "@DEFS@" to the DEFS in lib/Makefile.in such that the HAVE_PIPE2 is used correctly at build time.

2. Add back a few lines of code that were removed in #1429880. Specifically, the code in signal_handler_destroy():

--      close(signal_pipe[1]);
--      close(signal_pipe[0]);
--      signal_pipe[1] = -1;
--      signal_pipe[0] = -1;

Test results:

# rpm -q keepalived
keepalived-1.2.13-9.el7_3.1.x86_64

# keepalived -f /etc/keepalived/keepalived.conf 
# pstree -p $( cat /var/run/keepalived.pid )
keepalived(34937)─┬─keepalived(34938)
                                 └─keepalived(34939)

# lsof | grep 34937 | grep pipe | wc -l
2
# lsof | grep 34938 | grep pipe | wc -l
2
# lsof | grep 34939 | grep pipe | wc -l
2

# kill -HUP $( cat /var/run/keepalived.pid )

# lsof | grep 34937 | grep pipe | wc -l
2
# lsof | grep 34938 | grep pipe | wc -l
2
# lsof | grep 34939 | grep pipe | wc -l
2

Note that after SIGHUP each process should have exactly 2 pipes open. This is correct.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0183