Red Hat Bugzilla – Bug 1478001
Cannot edit new cluster memory optimization in Guide Me dialog
Last modified: 2018-02-12 06:47:37 EST
Created attachment 1308716 [details]
Description of problem:
I enabled Memory Optimization for Desktop Load and enabled KSM but there's still popup which informs one should enable KSM _or_ balooning. There's also *typo* in the message, it is not 'balooning' but 'ballooning'.
Error while executing action: KSM or balooning must be enabled to allow memory optimization
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. create new dc/cl
2. enable mem optimization for desktop load
3. enable ksm
4. click ok
popup which informs to either enable ksm or ballooning + typo in message
either it should work or message should replace 'or' to 'and', also no typo there.
Well, I can't "submit" the dialog even both KSM and ballooning is enabled.
It does not work from Guide Me dialog in this steps:
- create dc
- guide me (configure cluster)
- edit cluster settings with mem optimization
this fails but if you just save cluster without mem optimization and edit it to have mem optimization it does work.
Hi Greg, can the UX team help us with this? We have probably never touched the Guide me dialogs before.
"Guide Me" is just a dialog that links to other dialogs -- a "wizard". From what Jiri says, I'd guess the problem is still in the cluster dialog. But I can take a quick look.
Please do, it would help us tremendously.
Just for the record - optimization requires either ksm or ballooning to be enabled. So we either add that to the wizard as well or remove optimization from it.
Actually, Alexander, would you mind taking a look or offering your opinion? I don't know nearly as much about the model stuff as you do. Thanks!
This is a prime example of why copy and paste is bad. The problem is basically in DataCenterGuideModel we are passing the ClusterModel to the popup dialog and then once it returns we populate the object from that to pass to the back to create the new cluster. We do the same thing in the ClusterListModel. At some point in time those were the same, while changes happened to the dialog the cluster list model method was updated but since hardly anyone uses the DataCenterGuideModel it wasn't.
I will post a patch soon that will make the ClusterListModel method that populates the object for the backend public static and that will also call it from the DataCenterGuideModel.
@Martin this is all fixed now (thanks Alex!) so can target to 4.2.2
Steps of verification:
1. Create new DC
2. Guide me (configure cluster)
3. Edit cluster settings with memory optimization
4. Click OK
Enabling memory optimization without anything else results in:
"Error while executing action: KSM or ballooning must be enabled to allow memory optimization."
Enabling to the above memory balloon/KSM or both and clicking OK is working and creating a cluster.
This bugzilla is included in oVirt 4.2.1 release, published on Feb 12th 2018.
Since the problem described in this bug report should be
resolved in oVirt 4.2.1 release, it has been closed with a resolution of CURRENT RELEASE.
If the solution does not work for you, please open a new bug report.