Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-mixcloud.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-mixcloud-3.2-1.fc26.src.rpm Description: Mixcloud for Nuvola Player 3 : Integration of Mixcloud into your linux desktop via Nuvola Player Fedora Account System Username: martinkg %changelog * Fri Jul 28 2017 Martin Gansser <martinkg> - 3.2-1 - initial build rpmlint -i -v nuvola-app-mixcloud.spec /home/martin/rpmbuild/SRPMS/nuvola-app-mixcloud-3.2-1.fc26.src.rpm /home/martin/rpmbuild/RPMS/noarch/nuvola-app-mixcloud-3.2-1.fc26.noarch.rpm nuvola-app-mixcloud.spec: I: checking nuvola-app-mixcloud.spec:30: W: configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir} whenever the script supports it. nuvola-app-mixcloud.spec: I: checking-url https://github.com/tiliado/nuvola-app-mixcloud/archive/3.2.tar.gz#/nuvola-app-mixcloud-3.2.tar.gz (timeout 10 seconds) nuvola-app-mixcloud.src: I: checking nuvola-app-mixcloud.src: W: spelling-error %description -l en_US linux -> Linux The value of this tag appears to be misspelled. Please double-check. nuvola-app-mixcloud.src: I: checking-url https://github.com/tiliado/nuvola-app-mixcloud (timeout 10 seconds) nuvola-app-mixcloud.src:30: W: configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir} whenever the script supports it. nuvola-app-mixcloud.src: I: checking-url https://github.com/tiliado/nuvola-app-mixcloud/archive/3.2.tar.gz#/nuvola-app-mixcloud-3.2.tar.gz (timeout 10 seconds) nuvola-app-mixcloud.noarch: I: checking nuvola-app-mixcloud.noarch: W: spelling-error %description -l en_US linux -> Linux The value of this tag appears to be misspelled. Please double-check. nuvola-app-mixcloud.noarch: I: checking-url https://github.com/tiliado/nuvola-app-mixcloud (timeout 10 seconds) nuvola-app-mixcloud.noarch: W: desktopfile-without-binary /usr/share/applications/eu.tiliado.NuvolaAppMixcloud.desktop nuvola the .desktop file is for a file not present in the package. You should check the requires or see if this is not a error 2 packages and 1 specfiles checked; 0 errors, 5 warnings.
Going to take it for a review.
* Description - The description should not contain the "Mixcloud for Nuvola Player 3". It just duplicates summary. * Typo in .metainfo.xml - s/Intergration/Integration/ - BTW what is the point of the "-Integration" suffix? I'd say it would be probably better to leave it out. These are just minor nits and otherwise the package looks good => APPROVED
Thanks for the review. %changelog * Fri Aug 04 2017 Martin Gansser <martinkg> - 3.2-2 - correct %%description text - correct %%{name}.metainfo.xml
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nuvola-app-mixcloud
(fedrepo-req-admin): Apologies for the delay!
I have noticed typo in the .metainfo.xml: <name>Mixcload</name> It should be "Mixcloud".
(In reply to Vít Ondruch from comment #6) > I have noticed typo in the .metainfo.xml: > > <name>Mixcload</name> > > It should be "Mixcloud". corrected %changelog * Thu Aug 10 2017 Martin Gansser <martinkg> - 3.2-3 - correct %%{name}.metainfo.xml
new rpm packages: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-mixcloud.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-mixcloud-3.2-3.fc26.src.rpm
package has been built successfully on f25, f26 and rawhide.