Bug 1478088 - Review Request: nuvola-app-spotify - Spotify for Nuvola Player 3
Review Request: nuvola-app-spotify - Spotify for Nuvola Player 3
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Robert-André Mauchin
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2017-08-03 10:37 EDT by MartinKG
Modified: 2017-08-26 07:53 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2017-08-26 07:53:24 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
zebob.m: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description MartinKG 2017-08-03 10:37:05 EDT
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-spotify.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-spotify-2.3-1.fc26.src.rpm

Description: Nuvola Player runs web interface of cloud music service in its own
window and provides integration with a Linux desktop.

This package provides configuration information for Nuvola Player
to be used with Spotify service.

Fedora Account System Username: martinkg

* Fri Jul 28 2017 Martin Gansser <martinkg@fedoraproject.org> - 2.3-1
- initial build

rpmlint -i -v nuvola-app-spotify.spec /home/martin/rpmbuild/SRPMS/nuvola-app-spotify-2.3-1.fc26.src.rpm /home/martin/rpmbuild/RPMS/noarch/nuvola-app-spotify-2.3-1.fc26.noarch.rpm
nuvola-app-spotify.spec: I: checking
nuvola-app-spotify.spec:33: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.

nuvola-app-spotify.spec: I: checking-url https://github.com/tiliado/nuvola-app-spotify/archive/2.3.tar.gz#/nuvola-app-spotify-2.3.tar.gz (timeout 10 seconds)
nuvola-app-spotify.src: I: checking
nuvola-app-spotify.src: I: checking-url https://github.com/tiliado/nuvola-app-spotify (timeout 10 seconds)
nuvola-app-spotify.src:33: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.

nuvola-app-spotify.src: I: checking-url https://github.com/tiliado/nuvola-app-spotify/archive/2.3.tar.gz#/nuvola-app-spotify-2.3.tar.gz (timeout 10 seconds)
nuvola-app-spotify.noarch: I: checking
nuvola-app-spotify.noarch: I: checking-url https://github.com/tiliado/nuvola-app-spotify (timeout 10 seconds)
nuvola-app-spotify.noarch: W: desktopfile-without-binary /usr/share/applications/eu.tiliado.NuvolaAppSpotify.desktop nuvola
the .desktop file is for a file not present in the package. You should check
the requires or see if this is not a error

2 packages and 1 specfiles checked; 0 errors, 3 warnings.
Comment 1 Robert-André Mauchin 2017-08-25 08:49:11 EDT
No issue detected, package accepted.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* BSD (2 clause)", "BSD (2 clause)", "Unknown or
     generated". 9 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/nuvola-app-spotify/review-
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/nuvolaruntime/web_apps(nuvola-app-mixcloud, nuvola-app-
     bandcamp, nuvola-app-amazon-cloud-player, nuvolaruntime-devel)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
     contains icons.
     Note: icons in nuvola-app-spotify
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.

Checking: nuvola-app-spotify-2.3-1.fc28.noarch.rpm
nuvola-app-spotify.noarch: W: desktopfile-without-binary /usr/share/applications/eu.tiliado.NuvolaAppSpotify.desktop nuvola
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Comment 2 MartinKG 2017-08-25 09:51:35 EDT
Thanks for the review.
Comment 3 Gwyn Ciesla 2017-08-25 10:19:13 EDT
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nuvola-app-spotify
Comment 4 MartinKG 2017-08-26 07:53:24 EDT
package has been built successfully on f25, f26, f27 and rawhide.

Note You need to log in before you can comment on or make changes to this bug.