Bug 1478139 - Command "ovirt-log-collector --quiet" is verbose
Command "ovirt-log-collector --quiet" is verbose
Status: VERIFIED
Product: ovirt-log-collector
Classification: oVirt
Component: Core (Show other bugs)
4.1.3
All All
unspecified Severity medium (vote)
: ovirt-4.2.2
: 4.2.4
Assigned To: Douglas Schilling Landgraf
David Necpal
: Reopened
Depends On:
Blocks: 1456888
  Show dependency treegraph
 
Reported: 2017-08-03 13:01 EDT by David Necpal
Modified: 2018-02-22 08:08 EST (History)
6 users (show)

See Also:
Fixed In Version: ovirt-log-collector-4.2.4-1
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-08-07 05:11:50 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: Integration
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rule-engine: ovirt‑4.2+
ylavi: exception+


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
oVirt gerrit 86676 ovirt-log-collector-4.2 MERGED ovirt-log-collector: do not print msgs with --quiet 2018-02-14 05:33 EST
oVirt gerrit 87632 ovirt-log-collector-4.2 MERGED ovirt-log-collector: do not print msgs with --quiet 2018-02-14 05:56 EST

  None (edit)
Description David Necpal 2017-08-03 13:01:33 EDT
Description of problem:
The output lists information that is not necessary but deletes the necessary information about the name and size of the file.

Version-Release number of selected component (if applicable):
ovirt-log-collector-4.1.3

How reproducible:
Always

Steps to Reproduce:
1.ovirt-log-collector --quiet
2.
3.

Actual results:
[root@dn-0 tmp]# ovirt-log-collector --quiet
This command will collect system configuration and diagnostic
information from this system.
The generated archive may contain data considered sensitive and its
content should be reviewed by the originating organization before
being passed to any third party.
No changes will be made to system configuration.
Please provide the REST API password for the admin@internal oVirt Engine user (CTRL+D to skip): 
Creating compressed archive...

Expected results:
[root@dn-0 tmp]# ovirt-log-collector --quiet
Please provide the REST API password for the admin@internal oVirt Engine user (CTRL+D to skip): 

Additional info:
Comment 1 Sandro Bonazzola 2017-08-07 05:11:50 EDT
Closing as not a bug.
The warning exposed is meant to avoid to generate huge reports which takes hours to complete.
Comment 2 Lukas Svaty 2017-08-31 05:40:26 EDT
(In reply to Sandro Bonazzola from comment #1)
> Closing as not a bug.
> The warning exposed is meant to avoid to generate huge reports which takes
> hours to complete.

Which part is notifying admin about fact it can be a huge report lasting hours?
"""
This command will collect system configuration and diagnostic
information from this system.
The generated archive may contain data considered sensitive and its
content should be reviewed by the originating organization before
being passed to any third party.
No changes will be made to system configuration.
"""

Unfortunately, I do see an issue here, if we decided we want some kind of verbosity during --quite parameter:

1. Agree with reporter, all info should be hidden except asking for password
2. Not sure where this verbose mode is written to, but at least it should be written to stderr
3. If we are indeed writing something out to stdout we should consider at least adding name and path to the archive created, that seems like the most relevant info.

Can you reconsider?
Comment 3 Sandro Bonazzola 2017-09-08 05:29:49 EDT
Reopening as per comment #2
Comment 4 Douglas Schilling Landgraf 2018-01-05 14:46:55 EST
PR: https://github.com/oVirt/ovirt-log-collector/pull/2
Comment 5 Sandro Bonazzola 2018-01-15 02:43:30 EST
(In reply to Douglas Schilling Landgraf from comment #4)
> PR: https://github.com/oVirt/ovirt-log-collector/pull/2

Please push to gerrit.ovirt.org; github is backup only.
Comment 6 David Necpal 2018-02-22 08:08:52 EST
Verified on version ovirt-log-collector-4.2.4-1.el7ev.noarch
 
[root@example]# ovirt-log-collector --quiet
Please provide the REST API password for the admin@internal oVirt Engine user (CTRL+D to skip): 
[root@example]#

Note You need to log in before you can comment on or make changes to this bug.