Bug 1478470 - Full RELRO check does not support new dtags
Summary: Full RELRO check does not support new dtags
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rpmgrill
Version: 27
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Roman Joost
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-04 15:42 UTC by Petr Pisar
Modified: 2017-09-30 06:16 UTC (History)
3 users (show)

Fixed In Version: rpmgrill-0.31-1.fc25 rpmgrill-0.31-1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-16 03:23:45 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Fix (7.91 KB, patch)
2017-08-08 09:04 UTC, Petr Pisar
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1238804 0 unspecified CLOSED /usr/bin/perl is not linked with -z now and -pie, perl crashes with -pie 2021-02-22 00:41:40 UTC

Internal Links: 1238804

Description Petr Pisar 2017-08-04 15:42:42 UTC
If an executable is linked with --enable-new-dtags option, the BIND_NOW feature is encoded in a different way. Example:

$ readelf -d /usr/bin/rpm | grep NOW
 0x0000000000000018 (BIND_NOW)
 0x000000006ffffffb (FLAGS_1)            Flags: NOW PIE

$ readelf -d /usr/bin/perl | grep NOW
 0x000000000000001e (FLAGS)              BIND_NOW
 0x000000006ffffffb (FLAGS_1)            Flags: NOW PIE

eu-readelf output is similar. rpmgrill does not recognize BIND_NOW in FLAGS section and reports /usr/bin/perl is not full RELRO <https://taskotron.fedoraproject.org/artifacts/all/dc93a916-7698-11e7-9338-5254008e42f6/task_output/rpmgrill.json>.

This is a bug in rpmgrill. rpmgrill should support this variant.

Comment 1 Petr Pisar 2017-08-08 09:04:40 UTC
Created attachment 1310496 [details]
Fix

Comment 2 Roman Joost 2017-08-09 05:42:07 UTC
TIL never use "Raw Unified", because it misses new files from the patch. Sorry... I've botched applying your patch :(

Comment 3 Roman Joost 2017-08-11 06:14:09 UTC
I've merged the fix (also fixed the builds in copr).

Comment 4 Jan Kurik 2017-08-15 07:15:00 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle.
Changing version to '27'.

Comment 5 Fedora Update System 2017-09-05 03:51:00 UTC
rpmgrill-0.31-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ad93ec88d5

Comment 6 Fedora Update System 2017-09-05 04:02:40 UTC
rpmgrill-0.31-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9162792489

Comment 7 Fedora Update System 2017-09-05 04:22:35 UTC
rpmgrill-0.31-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-16bcdb8114

Comment 8 Fedora Update System 2017-09-06 22:23:29 UTC
rpmgrill-0.31-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-16bcdb8114

Comment 9 Fedora Update System 2017-09-06 22:28:47 UTC
rpmgrill-0.31-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9162792489

Comment 10 Fedora Update System 2017-09-07 14:30:20 UTC
rpmgrill-0.31-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ad93ec88d5

Comment 11 Fedora Update System 2017-09-15 22:22:23 UTC
rpmgrill-0.31-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2017-09-16 03:23:45 UTC
rpmgrill-0.31-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2017-09-30 06:16:33 UTC
rpmgrill-0.31-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.