Bug 1478823 - openstacknet driver should not run on external network nics (conflicts with OVN)
Summary: openstacknet driver should not run on external network nics (conflicts with OVN)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: General
Version: ---
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ovirt-4.1.6
: 4.1.6.1
Assignee: Marcin Mirecki
QA Contact: Mor
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-07 08:09 UTC by Marcin Mirecki
Modified: 2017-09-19 10:02 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2017-09-19 10:02:58 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.1+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 80155 0 master ABANDONED Openstacknet hooks must check provider type to run 2017-08-09 07:33:39 UTC
oVirt gerrit 80525 0 master MERGED Pass plugin type for each external network allocate request. 2017-08-30 06:24:53 UTC
oVirt gerrit 81191 0 ovirt-engine-4.1 MERGED engine: Pass plugin type for each external network allocate request. 2017-08-30 08:00:14 UTC

Description Marcin Mirecki 2017-08-07 08:09:22 UTC
The openstacknet driver should not run/fail for nic managed by external providers.
The hook scripts of the openstacknet driver currenlty fail on checking the pluginType, which might not be present for external providers.
The hooks should exit right after checking that the provider type is not "OPENSTACK_NETWORK".

How to reproduce:
- install both openstacknet and an external provider (like the OVN provider)
- create an nic on the OVN provider, plug/unplug/migrate the nic
- the openstacknet hooks should not interfere with this

Comment 1 Mor 2017-09-11 09:22:04 UTC
Verified on RHV-H host:
ovirt-provider-ovn-driver-1.0-8.el7ev.noarch
Red Hat Virtualization Manager Version: 4.1.6.2-0.1.el7

VM hosted on the host with OVN network is able to run, and I am able to do hot-unpluing and hot-plug of vNIC.


Dom XML:
...
        <interface type="bridge">
            <address bus="0x00" domain="0x0000" function="0x0" slot="0x03" type="pci" />
            <mac address="00:1a:4a:16:20:c1" />
            <model type="virtio" />
            <source bridge="ovirtmgmt" />
            <filterref filter="vdsm-no-mac-spoofing" />
            <link state="up" />
            <bandwidth />
        </interface>
...

Comment 2 Mor 2017-09-11 09:23:10 UTC
(In reply to Mor from comment #1)
> Verified on RHV-H host:
> ovirt-provider-ovn-driver-1.0-8.el7ev.noarch
> Red Hat Virtualization Manager Version: 4.1.6.2-0.1.el7
> 
> VM hosted on the host with OVN network is able to run, and I am able to do
> hot-unpluing and hot-plug of vNIC.
> 
> 
> Dom XML:
> ...
>         <interface type="bridge">
>             <address bus="0x00" domain="0x0000" function="0x0" slot="0x03"
> type="pci" />
>             <mac address="00:1a:4a:16:20:c1" />
>             <model type="virtio" />
>             <source bridge="ovirtmgmt" />
>             <filterref filter="vdsm-no-mac-spoofing" />
>             <link state="up" />
>             <bandwidth />
>         </interface>
> ...

Just adding, the packages on the host were grabbed manually.


Note You need to log in before you can comment on or make changes to this bug.