Description of problem:


Version-Release number of selected component (if applicable):

cockpit-system-138-9.el7.noarch

How reproducible:


Steps to Reproduce:
1. Set up or find a computer/vm/container with an ssh server that listens on a port other than 22. For testing you could just add "Port 600" to /etc/ssh/sshd_config, run "setenforce 0" and "systemctl stop sshd; systemctl start sshd" on the Cockpit machine.
2. Open Cockpit (e. g. https://localhost:9090) and log in
3. Change the URL to log in to the above remote host. In the scenario above this would be <https://localhost:9090/@127.0.0.1:600>. If you used another remote host, it would look like <https://localhost:9090/@my.remote.host:123>
4. Assuming that you never connected to that machine before, you will then get a "Couldn't connect to the machine" (unknown machine) warning with a Troubleshoot button. Click it.
5. Click the "Add machine" button in the troubleshoot dialog.

Actual results:

In step 5 the dialog will show an error "Failed to add machine: Unexpected type 'int' in argument".

Expected results:

In step 5 the dialog would close, the Cockpit UI changes to show the remote host, and /etc/cockpit/machines.d/99-webui.json has the new remote host with the appropriate port.


Additional info:

 * This does NOT happen when adding the remote host on the Dashboard (cockpit-dashboard package in Extras), which is the much more common way to talk to remote machines in Cockpit. Thus setting "Low" severity (but adjust as you see fit).

 * This got fixed upstream in Cockpit 140 by https://github.com/cockpit-project/cockpit/pull/6466 with a rather straightforward fix and a reproducer in the test suite.