Bug 1478854 - Edit Host/Kernel dialog should not accept blank char as value for Kernel command line
Summary: Edit Host/Kernel dialog should not accept blank char as value for Kernel comm...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.1.5.1
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.3.1
: ---
Assignee: Dominik Holler
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-07 10:36 UTC by Jiri Belka
Modified: 2019-03-13 16:39 UTC (History)
6 users (show)

Fixed In Version: ovirt-engine-4.3.1.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-13 16:39:30 UTC
oVirt Team: Virt
tjelinek: ovirt-4.3?
tjelinek: planning_ack?
rule-engine: devel_ack+
lleistne: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 93411 0 master MERGED webadmin: don't allow only whitespace for the kernel cmdline 2018-09-24 08:56:07 UTC
oVirt gerrit 94530 0 master MERGED webadmin: Allow empty string in NoSpacesValidation 2018-10-03 08:20:13 UTC
oVirt gerrit 97719 0 master MERGED webadmin: don't allow trimming whitespace for the kernel cmdline 2019-02-16 17:10:46 UTC

Description Jiri Belka 2017-08-07 10:36:55 UTC 
Description of problem:

blank char (whitespace) is accepted as value for Kernel command line in Edit Host/Kernel dialog. This causes options which can be (un)checked being disabled. It's not obvious there's whitespace in Kernel command line field.

Version-Release number of selected component (if applicable):
ovirt-engine-webadmin-portal-4.1.5.1-0.1.el7.noarch

How reproducible:
100%

Steps to Reproduce:
1. open Edit Host/Kernel dialog
2. click in Kernel command line and make whitespace
3. click ok

Actual results:
whitespace is accepted as value and this causes other "features" being disabled

Expected results:
blank char is not real value

Additional info:
Comment 1 Dominik Holler 2018-10-03 08:21:48 UTC 
On verification, please ensure that adding NFS data domain via web UI is still working, thanks.
Comment 2 Ryan Barry 2019-01-21 14:53:42 UTC 
Re-targeting to 4.3.1 since it is missing a patch, an acked blocker flag, or both
Comment 3 samuel macko 2019-02-13 13:47:49 UTC 
We don't have a proper build right now, please move to ON_QA when 4.3.1 will be available for QE.
Comment 4 Michael Burman 2019-03-07 10:02:39 UTC 
Verified on - rhvm-4.3.2-0.1.el7.noarch
Comment 5 Sandro Bonazzola 2019-03-13 16:39:30 UTC 
This bugzilla is included in oVirt 4.3.1 release, published on February 28th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.