Bug 14789 - gnomecc doesn't save sawfish configuration changes
Summary: gnomecc doesn't save sawfish configuration changes
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: sawfish
Version: 7.0
Hardware: i386
OS: Linux
high
medium
Target Milestone: ---
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2000-07-28 14:32 UTC by Trond Eivind Glomsrxd
Modified: 2008-05-01 15:37 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2000-08-21 14:07:20 UTC
Embargoed:


Attachments (Terms of Use)

Description Trond Eivind Glomsrxd 2000-07-28 14:32:35 UTC
When choosing not to display tooltips,  gnomecc applies this to sawfish but
doesn't save this state (and yes, I hit "OK", not "Try").

Here's a diff after disabling this:

[teg@hoser teg]$ diff -uNr .sawfish.orig/ .sawfish
diff -uNr .sawfish.orig/custom .sawfish/custom
--- .sawfish.orig/custom	Fri Jul 28 10:20:49 2000
+++ .sawfish/custom	Fri Jul 28 10:25:00 2000
@@ -1,5 +1,5 @@
 ;; sawfish user customization -- do not edit by hand!
-;; sawfish version 0.30.3, written Fri Jul 28 10:21:44 2000
+;; sawfish version 0.30.3, written Fri Jul 28 10:25:55 2000
 
 (custom-set-typed-variable (quote tooltips-enabled) (quote nil) (quote
boolean) (quote tooltips))
 (custom-set-keymap (quote global-keymap) (quote (keymap (cycle-windows .
"M-TAB") (move-viewport-right . "M-C-Right") (move-viewport-left .
"M-C-Left") (move-viewport-down . "M-C-Down") (move-viewport-up . "M-C-Up")
(xterm . "M-C-x") (delete-empty-workspaces . "M-C-D") (popup-window-list .
"M-ESC") ((run-shell-command "killall -9 netscape netscape-communicator
netscape-navigator") . "M-C-K") ((run-shell-command "netscape") .
"M-C-n"))))
[teg@hoser teg]$ 

As you can see, the only thing changed is the date.

Comment 1 Christian Rose 2000-08-04 12:47:17 UTC
Bug confirmed, and bug annoying.

Comment 2 Christian Rose 2000-08-04 14:12:07 UTC
This isn't just a bug with the tooltip displaying, there are many other
configuration options in sawfish that doesn't get changed when changed from
inside gnomecc.
For example, try to change the number of viewports... :-(

When I run sawfish-ui, I can change this, but not from gnomecc.

Seriously, IMHO this is a MUST-FIX, as a lot of users will get annoyed if they
can't change the default window manager behavior in Red Hat (sawfish-ui isn't
that well documented).


Comment 3 David Mason 2000-08-04 18:02:19 UTC
we think we are going to turn off the tool tips as they are large and ugly - but
we will look into the configuration tool not saving options...

Comment 4 Havoc Pennington 2000-08-07 03:32:51 UTC
Current info on this: if you hit "try" then "ok" it seems to work, if you hit 
only "ok" then it doesn't save. John Harper (sawfish author) says he couldn't
reproduce it, but he may have been hitting "try" first, I mentioned that to him.
Looking at the code, it looks to me like "try" and "ok" enter exactly the same
code path for saving the changes; I'll investigate further, first waiting to
hear back from John again.

Comment 5 Christian Rose 2000-08-07 09:16:40 UTC
I investigated this on my RH 6.2 + Helix system (sawfish 0.30.2, gnome-core
1.2.1) and it also behaves this way (you must hit "Try" before "OK").

Comment 6 Havoc Pennington 2000-08-21 14:06:37 UTC
Fix for this is in the test tree.


Note You need to log in before you can comment on or make changes to this bug.