Bug 1478965 - Vdsm shows traceback when HE VM powered-off
Vdsm shows traceback when HE VM powered-off
Status: POST
Product: vdsm
Classification: oVirt
Component: Core (Show other bugs)
4.20.0
x86_64 Linux
medium Severity low (vote)
: ovirt-4.2.0
: ---
Assigned To: Edward Haas
Artyom
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-07 11:15 EDT by Artyom
Modified: 2017-08-13 08:36 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: Network
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rule-engine: ovirt‑4.2+


Attachments (Terms of Use)
vdsm log (14.57 MB, text/plain)
2017-08-07 11:15 EDT, Artyom
no flags Details


External Trackers
Tracker ID Priority Status Summary Last Updated
oVirt gerrit 80393 master POST virt net: Avoid removing the display network when not defined 2017-08-08 07:15 EDT

  None (edit)
Description Artyom 2017-08-07 11:15:47 EDT
Created attachment 1310159 [details]
vdsm log

Description of problem:
Vdsm shows traceback when HE VM powered-off
2017-08-07 18:09:32,164+0300 ERROR (jsonrpc/0) [virt.vm] (vmId='b58fdeda-45bb-43d2-b336-ef9953171347') Failed to tear down device vnc, device in inconsist
ent state (vm:2120)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/vdsm/virt/vm.py", line 2117, in _teardown_devices
    device.teardown()
  File "/usr/lib/python2.7/site-packages/vdsm/virt/vmdevices/graphics.py", line 75, in teardown
    self.vmid)
  File "/usr/lib/python2.7/site-packages/vdsm/virt/libvirtnetwork.py", line 99, in delete_network
    removeNetwork(netname)
  File "/usr/lib/python2.7/site-packages/vdsm/virt/libvirtnetwork.py", line 110, in removeNetwork
    netName = LIBVIRT_NET_PREFIX + network
TypeError: cannot concatenate 'str' and 'NoneType' objects


Version-Release number of selected component (if applicable):
vdsm-4.20.2-25.git7499b81.el7.centos.x86_64
libvirt-client-3.2.0-14.el7_4.2.x86_64
ovirt-engine-4.2.0-0.0.master.20170803140556.git1e7d0dd.el7.centos.noarch

How reproducible:
Always

Steps to Reproduce:
1. Deploy hosted-engine
2. Add master storage domain
3. Wait for auto-import operation
4. Set global maintenance
5. Power off HE VM via HE CLI # hosted-engine --vm-poweroff

Actual results:
Action succeeds, but the traceback above appears under the vdsm log

Expected results:
Action succeeds, without any tracebacks under the VDSM log

Additional info:
Comment 1 Doron Fediuck 2017-08-08 05:31:37 EDT
Dan,
care to take a look?
By default hosted engine is not doing anything specific with the network, so this is new to me.
Comment 2 Dan Kenigsberg 2017-08-08 06:16:14 EDT
It smells as if Hosted Engine is relying on an ancient default, which Vdsm has recently dropped. Edy, would you care to look?

If my guess is correct, I'd rather we fix it in hosted engine.
Comment 3 Edward Haas 2017-08-08 07:00:02 EDT
If "displayNetwork" is not specified for a VM, we will encounter this problem.
When displayNetwork is not specified, the VM console can be reached from all existing interfaces which usually is not that safe.

We should fix this in both domains: Not to explode when it is missing and not to define a VM (Engine) with a missing displayNetwork.

Note You need to log in before you can comment on or make changes to this bug.