Bug 1478981 - meld no longer works after f26
meld no longer works after f26
Status: ASSIGNED
Product: Fedora
Classification: Fedora
Component: meld (Show other bugs)
26
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Dominic Hopf
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-07 11:52 EDT by Levente Farkas
Modified: 2017-08-10 02:56 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Levente Farkas 2017-08-07 11:52:17 EDT
on f25 everything was working while on the new version i always got this error:
-------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/meld/task.py", line 108, in iteration
    ret = next(task)
  File "/usr/lib/python3.6/site-packages/meld/dirdiff.py", line 768, in _search_recursively_iter
    allfiles = self._filter_on_state(roots, files.get())
  File "/usr/lib/python3.6/site-packages/meld/dirdiff.py", line 1271, in _filter_on_state
    if self.file_compare(curfiles, regexes) in (
  File "/usr/lib/python3.6/site-packages/meld/dirdiff.py", line 200, in _files_same
    contents = [remove_blank_lines(c) for c in contents]
  File "/usr/lib/python3.6/site-packages/meld/dirdiff.py", line 200, in <listcomp>
    contents = [remove_blank_lines(c) for c in contents]
  File "/usr/lib/python3.6/site-packages/meld/dirdiff.py", line 97, in remove_blank_lines
    return ''.join(lines)
TypeError: sequence item 0: expected str instance, bytes found
-------------------------------------


anyway when the latest released version is 3.16.4 while do you push a devel package into the stable repo??>?
Comment 1 Levente Farkas 2017-08-07 12:00:02 EDT
https://git.gnome.org/browse/meld/commit/?id=e4aa5761f4b536d13749f2ac5aaf2700979f9353

here is the patch fix solve it.
Comment 2 Dominic Hopf 2017-08-10 02:56:29 EDT
Hi Levente,

thanks very much for reporting this issue. Please note that I always build devel versions of meld for Fedora Rawhide (which is the development version of Fedora) only. It was a bit unlucky that the branch for Fedora 26 took place when Meld 3.17 was already in the Rawhide branch.

Of course I take the issue serious and I see there is a fix for it as well. However, I unfortunately am not able to reproduce it here in my Fedora 26 box and I'm curious what you actually did to trigger this issue?

Regards,
Dominic

Note You need to log in before you can comment on or make changes to this bug.