Red Hat Bugzilla – Bug 1479289
Error message failed to show up the first time typing invalid char in input box
Last modified: 2017-10-09 02:22:06 EDT
Description of problem:
Go to https://xxx:8443/console/project/xiaocwan-t/create?tab=deployImage
Select a imagestream and istag, try input "-" for image name without making cursor out, error message does not show up.
Version-Release number of selected component (if applicable):
OpenShift Master: v220.127.116.11.5
Steps to Reproduce:
1. Go to https://xxx:8443/console/project/xiaocwan-t/create?tab=deployImage
Select a imagestream and istag for "Image Stream Tag"
2. Try input "-" for image name without making cursor out
3. (For compare) Try to input "-" in Environment Variables without making cursor out
4. Refresh page, try one char and check error message, try input 2 chars and delete one, check error message again
2. Error message does not show up.
3. Error message shows up.
4. One char does not trigger error message, but it shows when the 2nd char is deleted
2 & 4: Error message should show up as soon as user input.
Step 2: "-" will trigger error message in Environment Variables when first time user input and keep cursor inside input box.
Step 4: it reproduced on both image name input box and Environment Variables
This is working as intended. In most inputs, we don't show errors until the user is done typing and the field loses focuses. This prevents red error messages from flickering and flashing annoyingly while the user types.
I understand this is different from the environment variables inputs. I'd argue that it's the environment variables inputs that are wrong. Leaving the bug open to fix that.
The following PR changes the environment variable editor inputs so that they will not show validation errors until they lose focus:
Commit pushed to master at https://github.com/openshift/origin-web-console
Bug 1479289 - Don't show env validation errors until blur
Wait until the input loses focus before showing validation errors in the
key value editor. This is consistent with our other forms and prevents
errors from flickering as the user types.
The environment variables inputs is now same as image name, that's the expected fix according to comment 1 and PR in comment 2. Behavior is that they will not show validation errors until they lose focus.
OpenShift Master: v3.7.0-0.143.1
Kubernetes Master: v1.7.0+80709908fd