Bug 1479427 - Invalid identifier in /usr/bin/docker-latest-storage-setup script
Invalid identifier in /usr/bin/docker-latest-storage-setup script
Status: NEW
Product: Fedora
Classification: Fedora
Component: docker-latest (Show other bugs)
x86_64 Linux
unspecified Severity unspecified
: ---
: ---
Assigned To: Lokesh Mandvekar
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2017-08-08 10:31 EDT by Lucas Maneos
Modified: 2017-08-09 07:29 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Lucas Maneos 2017-08-08 10:31:15 EDT
Description of problem:
The check_docker-latest_storage_metadata function in the docker-latest-storage-setup script uses a variable named "docker-latest_devmapper_meta_dir" which is not a valid shell variable identifier as it contains a "-" character.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Set the VG variable in /etc/sysconfig/docker-latest-storage-setup to an existing volume group
2. Run systemctl start docker-latest-storage-setup.service 

Actual results:
The service fails to start, and "docker-latest-storage-setup[7769]: /usr/bin/docker-latest-storage-setup: line 423: local: `docker-latest_devmapper_meta_dir=/var/lib/docker-latest/devicemapper/metadata/': not a valid identifier" gets logged in the journal.

Expected results:
The service starts and configures /etc/sysconfig/docker-latest-storage

Note You need to log in before you can comment on or make changes to this bug.