Bug 1479427 - Invalid identifier in /usr/bin/docker-latest-storage-setup script
Summary: Invalid identifier in /usr/bin/docker-latest-storage-setup script
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: docker-latest
Version: 28
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Lokesh Mandvekar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-08 14:31 UTC by Lucas Maneos
Modified: 2019-05-29 00:10 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-05-29 00:10:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Lucas Maneos 2017-08-08 14:31:15 UTC
Description of problem:
The check_docker-latest_storage_metadata function in the docker-latest-storage-setup script uses a variable named "docker-latest_devmapper_meta_dir" which is not a valid shell variable identifier as it contains a "-" character.

Version-Release number of selected component (if applicable):
docker-latest-1.13-32.git27e468e.fc26.x86_64

How reproducible:


Steps to Reproduce:
1. Set the VG variable in /etc/sysconfig/docker-latest-storage-setup to an existing volume group
2. Run systemctl start docker-latest-storage-setup.service 

Actual results:
The service fails to start, and "docker-latest-storage-setup[7769]: /usr/bin/docker-latest-storage-setup: line 423: local: `docker-latest_devmapper_meta_dir=/var/lib/docker-latest/devicemapper/metadata/': not a valid identifier" gets logged in the journal.

Expected results:
The service starts and configures /etc/sysconfig/docker-latest-storage

Comment 1 Jihad Dwidari 2017-12-23 14:47:37 UTC
Having the same issue today with this version
docker-latest-1.13-34.git27e468e.fc27.rpm

Comment 2 Lokesh Mandvekar 2018-01-03 13:43:43 UTC
Vivek, should this be docker_devmapper_meta_dir ??

Comment 3 Vivek Goyal 2018-01-03 13:53:08 UTC
Probably docker_latest_devmapper_meta_dir.

I think bash will not allow hypen in variable names. So you will have to use underscore.

Comment 4 Fedora End Of Life 2018-05-03 08:22:52 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 5 Lucas Maneos 2018-05-03 10:08:19 UTC
This is still observed with docker-latest-1.13-36.git27e468e.fc28.x86_64.

Comment 6 Brian Cook 2018-05-22 12:31:04 UTC
confirmed, also having this issue with docker-latest-1.13-36.git27e468e.fc28.x86_64 on F28.

Comment 7 Ben Cotton 2019-05-02 19:22:53 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 8 Ben Cotton 2019-05-29 00:10:25 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.