Bug 1479677 - [RFE] - LLDP protocol REST API support
Summary: [RFE] - LLDP protocol REST API support
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RFEs
Version: ---
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.1.6
: 4.1.6.1
Assignee: Dominik Holler
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On: 1477205
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-09 07:29 UTC by Dominik Holler
Modified: 2019-04-28 13:09 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
This update adds support for Link Layer Discovery Protocol (LLDP) in Red Hat Virtualization. To support the integration of Red Hat Virtualization with other software, the information gathered by LLDP on each host will be provided by the Manager's REST API. Information such as the switch port number the host's network interface is connected to, will be shown in the GUI. Known Issue BZ#1487930: Cisco switches might send VLAN tagged 802.1Q LLDP frames. These LLDP frames are ignored if the NIC of the Red Hat Virtualization host is not attached to the corresponding Red Hat Virtualization logical network.
Clone Of:
Environment:
Last Closed: 2017-09-19 10:01:11 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.1+
mburman: testing_plan_complete+
ylavi: planning_ack+
rule-engine: devel_ack+
mburman: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github https://github.com/oVirt ovirt-site pull 1174 0 None None None 2020-07-15 10:09:37 UTC
oVirt gerrit 78580 0 master MERGED restapi: Add LLDP 2020-07-15 10:09:39 UTC
oVirt gerrit 80186 0 ovirt-4.1 MERGED network: add driverloader module 2020-07-15 10:09:39 UTC
oVirt gerrit 80187 0 ovirt-4.1 MERGED net: Introduce the LLDPAD driver with an LLDP interface 2020-07-15 10:09:38 UTC
oVirt gerrit 80192 0 ovirt-4.1 MERGED net: Enable LLDP on NICs 2020-07-15 10:09:38 UTC
oVirt gerrit 80193 0 ovirt-4.1 MERGED net: Add info lldp to lldp 2020-07-15 10:09:38 UTC
oVirt gerrit 80194 0 ovirt-4.1 MERGED net: Report lldp through new getLldp command 2020-07-15 10:09:38 UTC
oVirt gerrit 80327 0 ovirt-4.1 MERGED net: Introduce network initializer module 2020-07-15 10:09:38 UTC
oVirt gerrit 80390 0 ovirt-4.1 MERGED net: Report empty LLDP TLV lists for operationally-down interfaces 2020-07-15 10:09:38 UTC
oVirt gerrit 80506 0 ovirt-engine-4.1 MERGED net: Add entities for LLDP 2020-07-15 10:09:37 UTC
oVirt gerrit 80509 0 ovirt-engine-4.1 MERGED core: Add GetTlvsByHostNicIdQuery 2020-07-15 10:09:37 UTC
oVirt gerrit 80511 0 ovirt-engine-4.1 MERGED restapi: Add LLDP 2020-07-15 10:09:37 UTC
oVirt gerrit 81119 0 ovirt-engine-4.1 MERGED restapi: Update to model 4.1.39 2020-07-15 10:09:37 UTC

Description Dominik Holler 2017-08-09 07:29:58 UTC 
Description of problem:

oVirt should provide Link Layer Discovery Protocol (LLDP) Support.
oVirt hosts should gather information from their networking interfaces and let oVirt Engine provide this information on REST-API, like described in https://github.com/oVirt/ovirt-site/pull/1027

Actual results:

No LLDP information in oVirt REST-API available

Expected results:

LLDP information in oVirt REST-API available
Comment 2 Meni Yakove 2017-08-28 08:53:09 UTC 
REST is not merged for 4.1

<host_nichref="/ovirt-engine/api/hosts/9d1d577b-a482-42ef-82c7-7d74169958fa/nics/eae47b64-a78a-4476-a74d-8f29b9ec7d62"id="eae47b64-a78a-4476-a74d-8f29b9ec7d62">
<actions/>
<name>enp2s0f0</name>
<linkhref="/ovirt-engine/api/hosts/9d1d577b-a482-42ef-82c7-7d74169958fa/nics/eae47b64-a78a-4476-a74d-8f29b9ec7d62/networklabels"rel="networklabels"/>
<linkhref="/ovirt-engine/api/hosts/9d1d577b-a482-42ef-82c7-7d74169958fa/nics/eae47b64-a78a-4476-a74d-8f29b9ec7d62/networkattachments"rel="networkattachments"/>
<linkhref="/ovirt-engine/api/hosts/9d1d577b-a482-42ef-82c7-7d74169958fa/nics/eae47b64-a78a-4476-a74d-8f29b9ec7d62/statistics"rel="statistics"/>
<boot_protocol>none</boot_protocol>
<bridged>false</bridged>
<ip>
<address/>
<netmask/>
<version>v4</version>
</ip>
<ipv6_boot_protocol>none</ipv6_boot_protocol>
<mac>
<address>00:e0:ed:33:c0:96</address>
</mac>
<mtu>1500</mtu>
<speed>1000000000</speed>
<status>up</status>
<hosthref="/ovirt-engine/api/hosts/9d1d577b-a482-42ef-82c7-7d74169958fa"id="9d1d577b-a482-42ef-82c7-7d74169958fa"/>
</host_nic>


No linklayerdiscoveryprotocolelements


Also the feature page says that in the REST the name is linklayerdiscoveryprotocolinformationelements but in REST it's linklayerdiscoveryprotocolelements
Comment 3 Red Hat Bugzilla Rules Engine 2017-08-28 16:40:02 UTC 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 4 Michael Burman 2017-08-31 12:41:22 UTC 
Hi Lev,

ON_QA on which version?
Comment 5 Sandro Bonazzola 2017-09-01 09:26:33 UTC 
Michael: 4.1.6.1
Comment 6 Michael Burman 2017-09-13 08:20:49 UTC 
We decided to verify this RFE with the known issue described in BZ 1487930(see comment#18).
"Cisco is sending LLDP packets encapsulated in VLAN1, which is probably the native tag on the port. This is a known problem of Cisco devices."
- If using a cisco switch user must create a vlan tagged network with vlan tag 1 and only then lldp will be work for the port. 
- This should be added in the know issues of the release. 

Verified on - 4.1.6.2-0.1.el7

Dominik please make sure this will documented as part of the known issues in the release note.
Note You need to log in before you can comment on or make changes to this bug.