Bug 1480750 - Review Request: golang-github-jdkato-syllables - Go port of the JavaScript syllable counter at github.com/wooorm/syllable
Review Request: golang-github-jdkato-syllables - Go port of the JavaScript sy...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Robert-André Mauchin
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 1480762
  Show dependency treegraph
 
Reported: 2017-08-11 15:43 EDT by Athos Ribeiro
Modified: 2017-08-15 10:06 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-08-15 10:06:11 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
zebob.m: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Athos Ribeiro 2017-08-11 15:43:45 EDT
Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-jdkato-syllables.spec
SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-jdkato-syllables-0.1.0-1.20170409git8961fa0.fc26.src.rpm
Description: Go port of the JavaScript syllable counter at github.com/wooorm/syllable
Fedora Account System Username: athoscr

rpmlint:
golang-github-jdkato-syllables.src: W: spelling-error Summary(en_US) wooorm -> woodworm, wormwood, bookworm
golang-github-jdkato-syllables.src: W: spelling-error %description -l en_US wooorm -> woodworm, wormwood, bookworm
golang-github-jdkato-syllables-devel.noarch: W: spelling-error Summary(en_US) wooorm -> woodworm, wormwood, bookworm
golang-github-jdkato-syllables-devel.noarch: W: spelling-error %description -l en_US wooorm -> woodworm, wormwood, bookworm
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
Comment 1 Robert-André Mauchin 2017-08-15 04:40:22 EDT
Hello,

No problem here, package accepted.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 10 files have
     unknown license. Detailed output of licensecheck in
     /home/bob/packaging/review/golang-github-jdkato-syllables/review-
     golang-github-jdkato-syllables/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gocode/src,
     /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
     github-jdkato-syllables-devel , golang-github-jdkato-syllables-unit-
     test-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: golang-github-jdkato-syllables-devel-0.1.0-1.20170409git8961fa0.fc27.noarch.rpm
          golang-github-jdkato-syllables-unit-test-devel-0.1.0-1.20170409git8961fa0.fc27.x86_64.rpm
          golang-github-jdkato-syllables-0.1.0-1.20170409git8961fa0.fc27.src.rpm
golang-github-jdkato-syllables-devel.noarch: W: spelling-error Summary(en_US) wooorm -> woodworm, wormwood, bookworm
golang-github-jdkato-syllables-devel.noarch: W: spelling-error %description -l en_US wooorm -> woodworm, wormwood, bookworm
golang-github-jdkato-syllables.src: W: spelling-error Summary(en_US) wooorm -> woodworm, wormwood, bookworm
golang-github-jdkato-syllables.src: W: spelling-error %description -l en_US wooorm -> woodworm, wormwood, bookworm
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
Comment 2 Athos Ribeiro 2017-08-15 09:08:16 EDT
Thanks for the review!
Comment 3 Gwyn Ciesla 2017-08-15 09:09:04 EDT
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-jdkato-syllables

Note You need to log in before you can comment on or make changes to this bug.