This service will be undergoing maintenance at 00:00 UTC, 2017-10-23 It is expected to last about 30 minutes
Bug 1480922 - python-pelican is shipped with an old version of feedgenerator.py which leads to unexpected behaviour
python-pelican is shipped with an old version of feedgenerator.py which leads...
Status: ASSIGNED
Product: Fedora
Classification: Fedora
Component: python-pelican (Show other bugs)
26
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Matthias Runge
Fedora Extras Quality Assurance
:
Depends On: 1379651
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-12 17:28 EDT by mdtha
Modified: 2017-09-11 16:25 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Github getpelican/pelican/issues/2202 None None None 2017-08-12 17:29 EDT

  None (edit)
Description mdtha 2017-08-12 17:28:52 EDT
Description of problem:
Pelican 3.7.1 shipped by Fedora 26 fails to generate <content> tags (which contain the full post, as opposed to <summary> tags which are generated) in the Atom XML output of the website, despite Pelican's documentation claiming that <content> tags should be present. 

This happens because Fedora uses an old version of feedgenerator.py (*afaik* provided by ython2-django-1.10.7-1.fc26.noarch), despite Pelican's build instructions requiring feedgenerator 1.9+.


Version-Release number of selected component (if applicable):
Pelican 3.7.1

How reproducible:
Always

Steps to Reproduce:
1. pelican-quikstart a new site
2. create one post
3. add "FEED_ALL_ATOM = 'feeds/atom.xml'" in the pelicanconf.py file
4. generate html output

Actual results:
feeds/atom.xml contains only <summary>

https://dpaste.de/mFDC

Expected results:
It should also include <content>. 


Additional info:
A lot of debug output here: https://github.com/getpelican/pelican/issues/2202#issuecomment-322002331

The version of pelican installed with pip works as expected, and uses feedgenerator-1.9.tar.gz.
Comment 1 mdtha 2017-08-12 17:40:32 EDT
Pelican contributor says that pelican's fork of feedgenerator.py has diverged from django's bundled module, so maybe packaging pelican's version might be necessary



>> Is pelican's feedgenerator.py just a standalone package for django's feedgenerator.py, or is it a fork?

> Originally just a standalone package, but since then, it may have diverged from Django's bundled version.

https://github.com/getpelican/pelican/issues/2202#issuecomment-322007448
Comment 2 Georg Sauthoff 2017-08-13 06:25:20 EDT
I can confirm this issue. With the Fedora 26 pelican version the atom feeds don't contain any content.

The version from pip works fine.

Thus, this is a regression to the official Pelican release and its documented behavior.

See also #1421185 for another issue that is caused by Fedora's choice to replace the Pelican feed-generator package with the incompatible django one.
Comment 3 Matthias Runge 2017-08-14 03:01:53 EDT
feedgenerator describes itself as 

Standalone version of django.utils.feedgenerator

https://pypi.python.org/pypi/feedgenerator/1.9

I see your issue. I would argue, forking and changing something instead of contributing back is not so nice as well. Django could benefit from enhancements as well....
Comment 4 mdtha 2017-08-14 03:51:33 EDT
This can be proposed back to the pelican developers, but from a Fedora POV, are we going to keep this package in a broken state?
Comment 5 Matthias Runge 2017-08-14 06:13:20 EDT
since there is no feedgenerator in fedora yet, there's not much I can do about it right now.
Comment 6 mdtha 2017-08-15 15:28:24 EDT
I was wondering if the features that break because of the dependency are considered serious enough to temporarily withdraw the package, so that users default to using the pip version.
Comment 7 Matthias Runge 2017-08-16 02:51:57 EDT
My 2 ct here:
- pip happily overwrites rpm package installed contents. The result is random. (That's going to change in f27)
- It depends on your usage, if the rss feed containing not all elements is "mission critical"
- If you want feedgenerator in fedora, please help with the review. I noted in the other bug, I'm fine with depending on feedgenerator (once in Fedora).
- From a general perspective, I disagree with pelican upstream to fork parts of Django; disagreement is fine, we all can grow on the arguments.
Comment 8 mdtha 2017-08-16 07:00:51 EDT
I'm not sure in what ways I can help with the review, never done this before, but I downloaded the spec file and I'll try to test if the package works.

Note You need to log in before you can comment on or make changes to this bug.