Red Hat Bugzilla – Bug 1480957
Review Request: golang-github-axgle-mahonia - Character-set conversion library implemented in Go
Last modified: 2017-10-11 02:27:16 EDT
Description: Character-set conversion library implemented in Go
Fedora Account System Username: mosquito
- Package does not contain duplicates in %files.
Note: warning: File listed twice:
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Shouldn't the Release tag include the git hash? There seems to be no released version.
+ package name is OK
? license is acceptable (MIT)
? license is not specified correctly
Where did you see the MIT license? README.md says this is derived from http://code.google.com/p/mahonia/, which lists BSD 3-clause.
Either way, you should open a ticket upstream asking for a license file to be included. Actually adding the license file is not necessary, but the ticket should be opened according to the guidelines [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text].
+ latest version
+ P/R/BR look OK
+ builds and install OK
+ fedora-review and rmplint are happy (modulo the issue listed above)
golang-github-BurntSushi-freetype-go-unit-test-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Blah, please ignore the last paragraph, I pasted the wrong text, the right rpmlint output is above.
I opened a new ticket in the upstream for license.
Release and license tag is fixed.
I think project owner is leave. Could you approve it?
Sorry for the delay, I am travelling.
Everything looks good, package is APPROVED.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-axgle-mahonia
golang-github-axgle-mahonia-0-0.1.gitc528b74.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b71d187af0
golang-github-axgle-mahonia-0-0.1.gitc528b74.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b71d187af0