Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1481217

Summary: While adding NIC with port mirroring to VM and running the VM, port mirroring doesn't configured on the bridge
Product: [oVirt] ovirt-engine Reporter: Ori Ben Sasson <obensass>
Component: BLL.NetworkAssignee: Arik <ahadas>
Status: CLOSED CURRENTRELEASE QA Contact: Meni Yakove <myakove>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.2.0CC: bugs, michal.skrivanek
Target Milestone: ovirt-4.2.0Keywords: Automation, Regression
Target Release: ---Flags: rule-engine: ovirt-4.2+
rule-engine: blocker+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-20 10:52:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
logs none

Description Ori Ben Sasson 2017-08-14 11:43:12 UTC
Created attachment 1313057 [details]
logs

Description of problem:
While adding NIC with port mirroring to VM and running the VM, port mirroring  doesn't configured on the bridge 

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.0-0.0.master.20170808202742.git7c42951.el7.centos.noarch
vdsm-4.20.2-2.git7ba8928.el7.centos.x86_64

How reproducible:
100

Steps to Reproduce:
1. Create network with port mirroring
2. Add NIC to VM
3. Run VM
4. Check if port mirroring is configured by running this command: 
   tc filter show dev <network_name>

Actual results:
We get nothing 

Expected results:
send tc filter show dev pm-net command

filter parent 803f: protocol all pref 49152 u32 
filter parent 803f: protocol all pref 49152 u32 fh 800: ht divisor 1 
filter parent 803f: protocol all pref 49152 u32 fh 800::800 order 2048 key ht 800 bkt 0 terminal flowid ??? 
  match 00000000/00000000 at 0
        action order 1: mirred (Egress Mirror to device vnet1) pipe
        index 180 ref 1 bind 1

Comment 1 Dan Kenigsberg 2017-08-14 13:21:11 UTC
I suspect that this is a regression due to the Engine domxml work.

Comment 2 Arik 2017-08-15 08:30:25 UTC
Indeed a regression caused by Engine XML.
Port mirroring used to be part of the configuration of the interface device sent to VDSM in the dictionary. It has no representation in libvirt's domain xml. So we need to add it in the engine to the metadata section of the Engine XML and fetch it from there in VDSM.

Comment 3 Meni Yakove 2017-09-28 08:37:29 UTC
ovirt-engine-4.2.0-0.0.master.20170926175518.git0d20200.el7.centos.noarch

Comment 4 Sandro Bonazzola 2017-12-20 10:52:27 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.