Spec URL: https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-x86_64/00590284-cmu-ipc/cmu-ipc.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-x86_64/00590284-cmu-ipc/cmu-ipc-3.9.1a-1.fc27.x86_64.rpm Description: IPC provides high-level support for connecting processes using TCP/IP sockets and sending data between processes. It takes care of opening sockets, registering messages, and sending and receiving messages, including both anonymous publish/subscribe and client/server type messages. Fedora Account System Username:yecheng The ppc64le version isn't really ready, It was not officially ported and there may be something other than alignment that is architecture specific but I don't have a machine to test. Testing and feedbacks are always welcomed!
Some general comments to your spec file: - Have you tried to send the patches to upstream? If yes, please note in a comment and you should add comments what those patches do. - According to the python guidelines, the subpackage must be called python2-cmu-ipc instead of cmu-ipc-python2. - Is it possible to build for python3, too? - Descriptions must split into several lines with line feeds. - Please use BR: java-devel instead of explicitly enforce java version 1.8 . - According to our java guidelines, add to the java subpackage: Require: java-headless - In %build you can use one line '%make_build install -S -C src' instead of additional cd . - Why is there no install script provided by upstream? Did you ask for some? - Changelog format is wrong. Must remove the single dash at the end and add a leading dash before the comment.
Thank you very much for your comments, I will try to address these issues in the next build.
(In reply to Raphael Groner from comment #1) New spec URL: https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-ppc64le/00593083-cmu-ipc/cmu-ipc.spec New srpm URL: https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-ppc64le/00593083-cmu-ipc/cmu-ipc-3.9.1a-1.fc28.src.rpm The java-cmu-ipc package provides and requires lib/Linux-4.11/libipcjava.so.3.9()(64bit) at the same time, and the location indicated by rpmbuild is its location at builddir instead of its installed location indicated in the install and file section. This seems to be erroneous, but I don't know what happened. > - Have you tried to send the patches to upstream? If yes, please note in a > comment and you should add comments what those patches do. Upstream haven't reply yet. This may take longer than expected, because the author is currently on leave. > - Is it possible to build for python3, too? Yes, it is now buildable with some patching. > - Why is there no install script provided by upstream? Did you ask for some? The install script (make install) provided by upstream is not readily usable. It doesn't distinguish build and install process. It attempts to access items at built location, but they are already moved by the install script at build time, because the install target becomes the dependency of building xdrgen, java and python (and the build script try to access the shared library at installed location). Other issues are fixed in this build. Thanks.
(In reply to Ye Cheng from comment #3) New spec URL: https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-i386/00593461-cmu-ipc/cmu-ipc.spec New srpm URL: https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-i386/00593461-cmu-ipc/cmu-ipc-3.9.1a-1.fc28.src.rpm > The java-cmu-ipc package provides and requires > lib/Linux-4.11/libipcjava.so.3.9()(64bit) at the same time, and the location > indicated by rpmbuild is its location at builddir instead of its installed > location indicated in the install and file section. This seems to be > erroneous, but I don't know what happened. Sorry the wrong “path" is because of my malformed soname but java-cmu-ipc still require and provides libipcjava.so.3.9 at the same time. python2 or python3 package do not have similar issue. Log is available at https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-i386/00593461-cmu-ipc/build.log.gz
Sorry, another rebuild. Removed unnecessary ldconfig for java package and make gcc wrapped ld honor ldflags. New srpm url: https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-x86_64/00593808-cmu-ipc/cmu-ipc-3.9.1a-1.fc28.src.rpm New spec url: https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-x86_64/00593808-cmu-ipc/cmu-ipc.spec
What's the status here? I see you set NotReady. Is this ready for another round of review?
Sorry, it is still not ready. The upstream is still on leave, but he will be back this year and I will repackage it after the update.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.