Bug 1481586 - engine-setup ovn plugin outputs to the user a plaintext password on failure
Summary: engine-setup ovn plugin outputs to the user a plaintext password on failure
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Setup.Engine
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ovirt-4.2.0
: ---
Assignee: Marcin Mirecki
QA Contact: Lucie Leistnerova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-15 06:35 UTC by Yedidyah Bar David
Modified: 2017-12-20 11:04 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-20 11:04:36 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 84482 0 master MERGED packaging: Do not show external network provider keystore password in dev mode 2017-11-29 14:43:23 UTC

Description Yedidyah Bar David 2017-08-15 06:35:45 UTC
Description of problem:

On the flow described in bug 1481583, we further output:

The following commands failed to execute.
Please execute them manually as root:
   keytool -import -alias ovirt-provider-ovn -keystore /var/lib/ovirt-engine/external_truststore -file /etc/pki/ovirt-engine/ca.pem -noprompt -storepass changeit

We should instead output something like this:

   . /usr/share/ovirt-engine/bin/engine-prolog.sh
   keytool -import -alias ovirt-provider-ovn -keystore /var/lib/ovirt-engine/external_truststore -file /etc/pki/ovirt-engine/ca.pem -noprompt -storepass "${ENGINE_EXTERNAL_PROVIDERS_TRUST_STORE_PASSWORD}"

So that someone looking behind the shoulder of the user, or seeing a copy/pasted
output posted somewhere for debugging etc., will not see the password.

This is not currently a security risk, because this file does not keep
secrets. This might change in future versions.

Comment 1 Lucie Leistnerova 2017-12-08 12:17:35 UTC
when import to trustore fails, engine-setup prints 
... -storepass "${ENGINE_EXTERNAL_PROVIDERS_TRUST_STORE_PASSWORD}

verified in ovirt-engine-setup-4.2.0-0.6.el7.noarch

Comment 2 Sandro Bonazzola 2017-12-20 11:04:36 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.