Bug 1481706 - disable default route role for clusters lower than 4.1 version
Summary: disable default route role for clusters lower than 4.1 version
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 4.2.0
Hardware: x86_64
OS: Linux
low
low
Target Milestone: ovirt-4.2.0
: 4.2.0
Assignee: eraviv
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks: 1200963
TreeView+ depends on / blocked
 
Reported: 2017-08-15 13:50 UTC by Michael Burman
Modified: 2017-12-20 10:52 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-20 10:52:48 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 81915 0 master MERGED webadmin: disable setting default route role for cluster levels <4.2 2017-11-08 10:03:36 UTC

Description Michael Burman 2017-08-15 13:50:03 UTC
Description of problem:
Ignore/disable default route checkboxes for clusters lower then 4.1 version.

If adding host with version lower then < 4.1 to engine 4.2, it is possible to set a non-mgmt network as default route, although it's not supported for version lower then <4.1.

We should block it? gray it out? disable for clusters lower then 4.1

Version-Release number of selected component (if applicable):
4.2.0-0.0.master.20170814200319.git3da5f35.el7.centos
Install host with vdsm-4.18.24-3.el7ev.x86_64

Comment 1 Dan Kenigsberg 2017-11-08 09:22:27 UTC
Placing proper severity, as this is an ugly regression imo.

Comment 2 Dan Kenigsberg 2017-11-08 09:24:32 UTC
oops, was confused my the much more important bug 1481718.

Comment 3 Michael Burman 2017-11-13 09:14:48 UTC
Dan , Eitan

What was fixed here? what is the difference between BZ 1481718 exactly, it has the same patches attached. 

Was it(default route property) grayed out for clusters lower than 4.1? 
why disabling also for 4.1 cluster? i'm a bit confused to be honest. it should have been for lower than 4.1(vdsm do report this for 4.1).

Comment 4 eraviv 2017-11-13 13:37:23 UTC
(In reply to Michael Burman from comment #3)
> Dan , Eitan
> 
> What was fixed here? what is the difference between BZ 1481718 exactly, it
> has the same patches attached. 
> 
> Was it(default route property) grayed out for clusters lower than 4.1? 
> why disabling also for 4.1 cluster? i'm a bit confused to be honest. it
> should have been for lower than 4.1(vdsm do report this for 4.1).

the fix for this bug is concerned with disabling in the UI. The other fix is concerned with reporting a synced network for host version < 4.1 even if the host reports it as not-synced.

Comment 5 eraviv 2017-11-13 13:39:17 UTC
Meni\Michael,

Are you certain that the fix should be for host version < 4.1 and not <= 4.1?

Thanks

Comment 6 Michael Burman 2017-11-13 13:49:38 UTC
(In reply to eraviv from comment #5)
> Meni\Michael,
> 
> Are you certain that the fix should be for host version < 4.1 and not <= 4.1?
> 
> Thanks

It depends, default route feature was introduced in 4.2, but vdsm 4.1 do report this property, so i don't think that the sync will be an issue for adding 4.1 hosts. But, i can't re-check my self, as i'm blocked from adding hosts lower than 4.2 to 4.2 engine(required ovirt-host package). 
I think that when i reported the bug, i was talking about hosts lower than 4.1, because i think that 4.1 was in sync(because vdsm do report the default route property..).
Any how, we are ok with the fix for <=4.1 as it make sense and the feature supported from 4.2 only.

Comment 7 Michael Burman 2017-11-14 06:23:27 UTC
Verified on - 4.2.0-0.0.master.20171112130303.git8bc889c.el7.centos

The default route property is now grayed out for both flows, for clusters <=4.1 -
Network>Cluster>Manage networks flow - The default route checkbox is grayed out.
Cluster>Logical networks>Manage networks flow - The default route radio button is grayed out.

The default route role is now disabled for clusters lower than <=4.1, i will report new bug to add a tooltip in the manage networks dialog to explain the reason it's grayed out in clusters <=4.1.

Comment 8 Sandro Bonazzola 2017-12-20 10:52:48 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.